| Summary: | Update block direction overflow for lines to be writing-mode-aware. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dave Hyatt <hyatt> | ||||
| Component: | Layout and Rendering | Assignee: | Dave Hyatt <hyatt> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, eric, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | PC | ||||||
| OS: | OS X 10.5 | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 46123 | ||||||
| Attachments: |
|
||||||
|
Description
Dave Hyatt
2010-10-22 13:05:27 PDT
Created attachment 71589 [details]
Patch
Comment on attachment 71589 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=71589&action=review > WebCore/rendering/style/RenderStyle.h:644 > + void getTextShadowBlockDirectionExtent(int& logicalTop, int & logicalBottom) { getShadowBlockDirectionExtent(textShadow(), logicalTop, logicalBottom); } Weird spacing around the &. > WebCore/rendering/style/RenderStyle.h:664 > + void getBoxShadowBlockDirectionExtent(int& logicalTop, int & logicalBottom) { getShadowBlockDirectionExtent(boxShadow(), logicalTop, logicalBottom); } Here too. http://trac.webkit.org/changeset/70330 might have broken SnowLeopard Intel Release (Tests) The following tests are not passing: fast/forms/basic-textareas-quirks.html fast/forms/basic-textareas.html platform/mac/scrollbars/key-window-not-first-responder.html scrollbars/overflow-scrollbar-combinations.html Silly mistake. Will land fix shortly. |