Bug 48130

Summary: dumpAsText conversion: editing/deleting/delete-by-word-001.html and delete-by-word-002.html
Product: WebKit Reporter: Antonio Gomes <tonikitoo>
Component: HTML EditingAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, ojan, rniwa, tkent, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
converted tests tony: review+

Description Antonio Gomes 2010-10-22 07:16:54 PDT
It makes the expectation result file too platform dependent.

Maybe converting it to PASS/FAIL output logic.
Comment 1 Ryosuke Niwa 2010-11-17 11:14:29 PST
We should convert editing/deleting/delete-by-word-001.html and delete-by-word-002.html to dumpAsText tests.
Comment 2 Ryosuke Niwa 2010-11-17 11:14:56 PST
*** Bug 48131 has been marked as a duplicate of this bug. ***
Comment 3 Ryosuke Niwa 2010-11-17 11:23:13 PST
Created attachment 74135 [details]
converted tests
Comment 4 Ryosuke Niwa 2010-11-22 14:15:33 PST
Hi Antonio, did these tests pass on Qt?
Comment 5 Antonio Gomes 2010-11-22 18:59:20 PST
(In reply to comment #4)
> Hi Antonio, did these tests pass on Qt?

$ WEBKITOUTPUTDIR=`pwd`/WebKitBuild/Qt run-webkit-tests --qt LayoutTests/editing/deleting/delete-by-word-00*.html
Running build-dumprendertree
Running tests from /home/agomes/Devel/webkit/webkit/LayoutTests
Testing 2 test cases.
editing/deleting ..
3.31s total testing time

all 2 test cases succeeded
Comment 6 Ryosuke Niwa 2010-11-22 19:13:10 PST
(In reply to comment #5)
> (In reply to comment #4)
> > Hi Antonio, did these tests pass on Qt?
> 
> $ WEBKITOUTPUTDIR=`pwd`/WebKitBuild/Qt run-webkit-tests --qt LayoutTests/editing/deleting/delete-by-word-00*.html
> Running build-dumprendertree
> Running tests from /home/agomes/Devel/webkit/webkit/LayoutTests
> Testing 2 test cases.
> editing/deleting ..
> 3.31s total testing time
> 
> all 2 test cases succeeded

Great!
Comment 7 Ryosuke Niwa 2010-11-23 15:29:09 PST
Thanks for the review, Tony.  Will land.
Comment 8 Ryosuke Niwa 2010-11-23 15:39:58 PST
Committed r72637: <http://trac.webkit.org/changeset/72637>
Comment 9 WebKit Review Bot 2010-11-23 16:22:07 PST
http://trac.webkit.org/changeset/72637 might have broken GTK Linux 32-bit Release
The following tests are not passing:
editing/deleting/delete-by-word-001.html