Bug 48125

Summary: Further preparations to deploy the new SVGAnimatedProperty concept for the rest of the SVG datatypes
Product: WebKit Reporter: Nikolas Zimmermann <zimmermann>
Component: SVGAssignee: Nikolas Zimmermann <zimmermann>
Status: RESOLVED FIXED    
Severity: Normal CC: krit, mdelaney7, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 47905    
Attachments:
Description Flags
Patch
none
Patch v2 krit: review+

Nikolas Zimmermann
Reported 2010-10-22 05:30:03 PDT
SVGListPropertyTearOff & friends need some futher tweaks, to allow more datatypes to use them.
Attachments
Patch (21.56 KB, patch)
2010-10-22 05:33 PDT, Nikolas Zimmermann 		no flags
DetailsFormatted DiffDiff
Patch v2 (21.77 KB, patch)
2010-10-22 06:13 PDT, Nikolas Zimmermann 		krit: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Nikolas Zimmermann
Comment 1 2010-10-22 05:33:29 PDT
Created attachment 71554 [details] Patch
Nikolas Zimmermann
Comment 2 2010-10-22 06:13:17 PDT
Created attachment 71557 [details] Patch v2 Ouch, forgot the destructor. SVGPropertyTearOff does it right, SVGListPropertyTearOff also needs to delete m_values if m_valuesIsCopy=true. The code is yet unused, when I convert SVGStringList to use this new code, I would have noticed it on a leaks run...
Dirk Schulze
Comment 3 2010-10-22 06:25:12 PDT
Comment on attachment 71557 [details] Patch v2 LGTM. r=me
Nikolas Zimmermann
Comment 4 2010-10-22 06:26:58 PDT
Landed in r70303.
Note You need to log in before you can comment on or make changes to this bug.