Bug 48125

Summary: Further preparations to deploy the new SVGAnimatedProperty concept for the rest of the SVG datatypes
Product: WebKit Reporter: Nikolas Zimmermann <zimmermann>
Component: SVGAssignee: Nikolas Zimmermann <zimmermann>
Severity: Normal CC: krit, mdelaney7, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 47905    
Description Flags
Patch v2 krit: review+

Description Nikolas Zimmermann 2010-10-22 05:30:03 PDT
SVGListPropertyTearOff & friends need some futher tweaks, to allow more datatypes to use them.
Comment 1 Nikolas Zimmermann 2010-10-22 05:33:29 PDT
Created attachment 71554 [details]
Comment 2 Nikolas Zimmermann 2010-10-22 06:13:17 PDT
Created attachment 71557 [details]
Patch v2

Ouch, forgot the destructor. SVGPropertyTearOff does it right, SVGListPropertyTearOff also needs to delete m_values if m_valuesIsCopy=true.
The code is yet unused, when I convert SVGStringList to use this new code, I would have noticed it on a leaks run...
Comment 3 Dirk Schulze 2010-10-22 06:25:12 PDT
Comment on attachment 71557 [details]
Patch v2

LGTM. r=me
Comment 4 Nikolas Zimmermann 2010-10-22 06:26:58 PDT
Landed in r70303.