Summary: | Further preparations to deploy the new SVGAnimatedProperty concept for the rest of the SVG datatypes | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Nikolas Zimmermann <zimmermann> | ||||||
Component: | SVG | Assignee: | Nikolas Zimmermann <zimmermann> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | krit, mdelaney7, zimmermann | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | OS X 10.5 | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 47905 | ||||||||
Attachments: |
|
Description
Nikolas Zimmermann
2010-10-22 05:30:03 PDT
Created attachment 71554 [details]
Patch
Created attachment 71557 [details]
Patch v2
Ouch, forgot the destructor. SVGPropertyTearOff does it right, SVGListPropertyTearOff also needs to delete m_values if m_valuesIsCopy=true.
The code is yet unused, when I convert SVGStringList to use this new code, I would have noticed it on a leaks run...
Comment on attachment 71557 [details]
Patch v2
LGTM. r=me
|