| Summary: | Web Inspector: update resources tree in storage panel upon network events. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Pavel Feldman <pfeldman> | ||||
| Component: | Web Inspector (Deprecated) | Assignee: | Pavel Feldman <pfeldman> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | apavlov, bweinstein, commit-queue, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Pavel Feldman
2010-10-22 04:10:55 PDT
Created attachment 71546 [details]
[PATCH] Proposed change.
Comment on attachment 71546 [details] [PATCH] Proposed change. View in context: https://bugs.webkit.org/attachment.cgi?id=71546&action=review > WebCore/inspector/InspectorResourceAgent.cpp:354 > + frameObject->setNumber("parentId", reinterpret_cast<uintptr_t>(frame->tree()->parent())); can we extract this reinterpret_cast into a function that would convert to the id for us? > WebCore/inspector/front-end/StoragePanel.js:187 > + (child._resource.type !== WebInspector.Resource.Type.Document && child._resource.displayName.localeCompare(resource.displayName) > 0)) { style: wrong alignment (In reply to comment #2) > (From update of attachment 71546 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=71546&action=review > > > WebCore/inspector/InspectorResourceAgent.cpp:354 > > + frameObject->setNumber("parentId", reinterpret_cast<uintptr_t>(frame->tree()->parent())); > > can we extract this reinterpret_cast into a function that would convert to the id for us? > Will fix in the next patch. Comment on attachment 71546 [details] [PATCH] Proposed change. Clearing flags on attachment: 71546 Committed r70305: <http://trac.webkit.org/changeset/70305> All reviewed patches have been landed. Closing bug. |