Bug 48121 – Web Inspector: update resources tree in storage panel upon network events.

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Pavel Feldman]

We now have live frame tree with resources no matter whether resource tracking is on or off.

[Pavel Feldman]

Created attachment 71546 [details]
[PATCH] Proposed change.

[Yury Semikhatsky]

Comment on attachment 71546 [details]
[PATCH] Proposed change.

View in context: https://bugs.webkit.org/attachment.cgi?id=71546&action=review

> WebCore/inspector/InspectorResourceAgent.cpp:354
> +    frameObject->setNumber("parentId", reinterpret_cast<uintptr_t>(frame->tree()->parent()));

can we extract this reinterpret_cast into a function that would convert to the id for us?

> WebCore/inspector/front-end/StoragePanel.js:187
> +                    (child._resource.type !== WebInspector.Resource.Type.Document && child._resource.displayName.localeCompare(resource.displayName) > 0)) {

style: wrong alignment

[Pavel Feldman]

(In reply to comment #2)
> (From update of attachment 71546 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=71546&action=review
> 
> > WebCore/inspector/InspectorResourceAgent.cpp:354
> > +    frameObject->setNumber("parentId", reinterpret_cast<uintptr_t>(frame->tree()->parent()));
> 
> can we extract this reinterpret_cast into a function that would convert to the id for us?
> 

Will fix in the next patch.

[WebKit Commit Bot]

Comment on attachment 71546 [details]
[PATCH] Proposed change.

Clearing flags on attachment: 71546

Committed r70305: <http://trac.webkit.org/changeset/70305>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.