Bug 48100

Summary:

YARR allows what seems like a bogus character-class range

Product:

WebKit

Reporter:

Oliver Hunt <oliver>

Component:

JavaScriptCore

Assignee:

Gavin Barraclough <barraclough>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

URL:

https://bugzilla.mozilla.org/show_bug.cgi?id=576837

Bug Depends on:

Bug Blocks:

50320

Attachments:

Description	Flags
The patch	sam: review+

Oliver Hunt

Reported 2010-10-21 16:33:09 PDT

[reply] [-] Description Jesse Ruderman 2010-07-04 00:29:26 PDT /[C-\s]/; YARR: accepts it OLD: "invalid range in character class" [reply] [-] Comment 1 Jesse Ruderman 2010-07-04 00:50:15 PDT Same with /[f-\d]/

Attachments
The patch (32.54 KB, patch) 2010-11-29 00:11 PST, Gavin Barraclough	sam: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Oliver Hunt

Comment 1 2010-10-25 15:18:47 PDT

https://bugzilla.mozilla.org/show_bug.cgi?id=576837 has a fix for this but it would need to be merged

Gavin Barraclough

Comment 2 2010-11-29 00:11:34 PST

Created attachment 74993 [details] The patch

Sam Weinig

Comment 3 2010-11-29 08:37:11 PST

Comment on attachment 74993 [details] The patch View in context: https://bugs.webkit.org/attachment.cgi?id=74993&action=review > JavaScriptCore/yarr/RegexParser.h:205 > empty, > cachedCharacter, > cachedCharacterHyphen, > + afterCharacterClass, > + afterCharacterClassHyphen, Eek. This enum should have initial capital letters.

Gavin Barraclough

Comment 4 2010-11-29 11:00:59 PST

Fixed in r72813.

Note You need to log in before you can comment on or make changes to this bug.