Bug 48092

Summary:

Crash evaluating JavaScript string that throws an exception

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

WebKit2

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

Keywords:

InRadar

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	aroben: review+

Description Anders Carlsson 2010-10-21 14:33:01 PDT

Crash evaluating JavaScript string that throws an exception

Comment 1 Anders Carlsson 2010-10-21 14:36:00 PDT

<rdar://problem/8487657>

Comment 2 Anders Carlsson 2010-10-21 14:37:22 PDT

Created attachment 71495 [details]
Patch

Comment 3 Adam Roben (:aroben) 2010-10-21 14:40:06 PDT

Comment on attachment 71495 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=71495&action=review

> WebKitTools/ChangeLog:15
> +        (TestWebKitAPI::TEST):

I've been replacing this line with TestWebKitAPI::WebKit2_EvaluateJavaScript (e.g.).

> WebKitTools/TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:42
> +    // FIXME: We should also check the error, but right now it's always null.

Maybe you should TEST_ASSERT that it is null. Then we will have something reminding us we need to update this test when we make it be non-null!

Comment 4 Anders Carlsson 2010-10-21 14:48:08 PDT

Committed r70267: <http://trac.webkit.org/changeset/70267>