Bug 48088 – Add --suggest-reviewers option to upload to auto-suggest reviewers for your patch

• Component: New Bugs
• Status: RESOLVED FIXED

[Eric Seidel (no email)]

Add --suggest-reviewers option to upload to auto-suggest reviewers for your patch

[Eric Seidel (no email)]

Created attachment 71475 [details]
Patch

[Eric Seidel (no email)]

For example, when uploading this patch, this is the output:

% webkit-patch upload --suggest-reviewers --request-commit                                                                             Parsing ChangeLog: /Projects/WebKit/WebKitTools/ChangeLog
Running check-webkit-style
Total errors found: 0 in 8 files
Using editor in the CHANGE_LOG_EDIT_APPLICATION environment variable.
Please quit the editor application when done editing.
Was that diff correct? [Y/n]: 
Fetching: https://bugs.webkit.org/show_bug.cgi?id=48088&ctype=xml
The following reviewers have recently modified files in your patch:
Adam Barth
Chris Jerdonek
Daniel Bates
David Levin
Eric Seidel
Ojan Vafai
Would you like to CC them? [Y/n]: 
Reading Keychain for bugs.webkit.org account and password.  Click "Allow" to continue...
Logging in as [e-mail]...
Adding ['[e-mail]', '[e-mail]', '[e-mail]', '[e-mail]', '[e-mail]', '[e-mail]'] to the CC list for bug 48088
Adding patch "Patch" to https://bugs.webkit.org/show_bug.cgi?id=48088

[Eric Seidel (no email)]

We'll definitely want to refine this further, but as-is this is *hugely* useful to me when uploading patches.  I hope it's useful to others.

[Adam Barth]

Comment on attachment 71475 [details]
Patch

Donde esta la stepe?

[Eric Seidel (no email)]

Created attachment 71488 [details]
Patch

[Adam Barth]

Comment on attachment 71488 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=71488&action=review

Also, it should work for post!

> WebKitTools/Scripts/webkitpy/tool/steps/suggestreviewers.py:45
> +        reviewers = self._tool.checkout().suggested_reviewers(self._options.git_commit)

You're not passing in the set of changed_files.

> WebKitTools/Scripts/webkitpy/tool/steps/suggestreviewers.py:50
> +        reviewer_emails = [reviewer.bugzilla_email() for reviewer in reviewers]

You can use map for this if you like.

[Eric Seidel (no email)]

Created attachment 71490 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 71490 [details]
Patch

Clearing flags on attachment: 71490

Committed r70274: <http://trac.webkit.org/changeset/70274>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.