Bug 48062

Summary:

Add cmn to branch32(reg, imm) on ARM

Product:

WebKit

Reporter:

Gabor Loki <loki>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Enhancement

CC:

barraclough, commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

All

Attachments:

Description	Flags
Add cmn to branch32(reg, imm) on ARM	none

Gabor Loki

Reported 2010-10-21 04:21:29 PDT

There is a missing optimization in the branch32(cond, reg, imm) function on ARM. The conditional comparison can be done with cmn if the imm value is negative and can fit into the cmn instruction.

Attachments
Add cmn to branch32(reg, imm) on ARM (1.99 KB, patch) 2010-10-21 04:25 PDT, Gabor Loki	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Gabor Loki

Comment 1 2010-10-21 04:25:10 PDT

Created attachment 71423 [details] Add cmn to branch32(reg, imm) on ARM

WebKit Commit Bot

Comment 2 2010-10-27 06:48:23 PDT

Comment on attachment 71423 [details] Add cmn to branch32(reg, imm) on ARM Clearing flags on attachment: 71423 Committed r70642: <http://trac.webkit.org/changeset/70642>

WebKit Commit Bot

Comment 3 2010-10-27 06:48:28 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.