Bug 48041

Summary:	`webkit-patch upload` runs git-diff at least 3 times, which is slow
Product:	WebKit	Reporter:	Adam Roben (:aroben) <aroben>
Component:	Tools / Tests	Assignee:	Nobody <webkit-unassigned>
Status:	NEW ---
Severity:	Normal	CC:	abarth, eric
Priority:	P2
Version:	528+ (Nightly build)
Hardware:	All
OS:	All
See Also:	https://bugs.webkit.org/show_bug.cgi?id=242319
Bug Depends on:	39207
Bug Blocks:

Description Adam Roben (:aroben) 2010-10-20 22:36:58 PDT

`webkit-patch upload` runs git-diff at least 3 times:

1) when finding ChangeLogs to parse for bug IDs
2) when running check-webkit-style (I think)
3) when creating the diff to present to the user for confirmation

There might be other instances of git-diff that I've missed.

It would be faster if we could just run git-diff once.

Comment 1 Adam Barth 2010-10-20 22:46:08 PDT

Yeah, I recently removed one of them (by sharing the one for prepare-ChangeLog with another one we do).  We should be able to remove the one for check-webkit-style by passing it the list of changed files.  However, passing them today gives you different output.  We need to teach check-webkit-style to diff a set of files provided on the command line.  It's not that much code.

Comment 2 Eric Seidel (no email) 2010-10-21 08:17:22 PDT

I'm pretty sure we have another bug on this somewhere...

Comment 3 Eric Seidel (no email) 2010-10-21 08:18:12 PDT

See bug 39207.