Bug 48033
| Summary: | Remove the destructors of Safari's DatabaseTracker clients on Windows and Mac | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Dumitru Daniliuc <dumi> |
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | andersca, ap, beidson, darin, levin |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
Dumitru Daniliuc
WebKit/win/WebDatabaseManager.h and WebKit/mac/Storage/WebDatabaseTrackerClient.h should have destructor declarations, but should not implement them, since they're supposed to be singletons that are never destroyed.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Anders Carlsson
Maybe we should add a WTF macro for declaring a class as not being destructable. On C++0x compilers we could then use = delete, just like we do for WTF_MAKE_NONCOPYABLE.
Darin Adler
(In reply to comment #1)
> Maybe we should add a WTF macro for declaring a class as not being destructable. On C++0x compilers we could then use = delete, just like we do for WTF_MAKE_NONCOPYABLE.
I think we should do that.
Anders Carlsson
(In reply to comment #2)
> I think we should do that.
WTF_MAKE_NONDESTRUCTABLE? WTF_MAKE_INDESTRUCTABLE? :)
Darin Adler
WTF_MAKE_NONDESTRUCTIBLE would be a good name.