Bug 48025

Summary: [Chromium] Remove chromium baseline for http/tests/plugins/geturlnotify-from-npp-destroystream.html
Product: WebKit Reporter: Julie Parent <jparent>
Component: Tools / TestsAssignee: Julie Parent <jparent>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch none

Julie Parent
Reported 2010-10-20 16:33:36 PDT
Currently, this test: Is skipped on Mac Passes ~100% on Linux Fails ~100% on Win The chromium baseline is the mac baseline + a console error message. Win is failing because it matches the upstream expectation, aka, it does not print out an error. Linux passes because it does have the error. Matching upstream expectation and updating test_expectations for new failures seems correct, rather than adding a linux baseline with the error message.
Attachments
Patch (84.73 KB, patch)
2010-10-20 16:52 PDT, Julie Parent 		no flags
DetailsFormatted DiffDiff
Patch (2.26 KB, patch)
2010-10-20 16:58 PDT, Julie Parent 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tony Chang
Comment 1 2010-10-20 16:51:13 PDT
FWIW, I'm trying to switch to using the webkit.org test plugin. I've already made the switch for chromium DRT mac, so it would be good to know if this test passes with chromium DRT mac.
Julie Parent
Comment 2 2010-10-20 16:52:45 PDT
Created attachment 71364 [details] Patch
Julie Parent
Comment 3 2010-10-20 16:53:35 PDT
Comment on attachment 71364 [details] Patch Not sure what happened with ChangeLog there. Fixing.
Julie Parent
Comment 4 2010-10-20 16:58:45 PDT
Created attachment 71368 [details] Patch
Julie Parent
Comment 5 2010-10-20 17:01:22 PDT
I don't have a Mac, but I could try unskipping in test_expectations and see what happens? I don't see a good reason for this to be skipped anyway.
Tony Chang
Comment 6 2010-10-20 17:11:51 PDT
Comment on attachment 71368 [details] Patch Deleting the wrong baseline seems fine. It would be good to try to unskip this test on Mac, but that can be a separate change.
WebKit Commit Bot
Comment 7 2010-10-21 15:16:42 PDT
The commit-queue encountered the following flaky tests while processing attachment 71368 [details]: java/lc3/JSObject/ToObject-001.html Please file bugs against the tests. The author(s) of the test(s) are ap@webkit.org and ap@webkit.org. The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 8 2010-10-21 15:17:43 PDT
Comment on attachment 71368 [details] Patch Clearing flags on attachment: 71368 Committed r70271: <http://trac.webkit.org/changeset/70271>
WebKit Commit Bot
Comment 9 2010-10-21 15:17:49 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.