Bug 48015

Summary: Add Git-support to do-file-rename
Product: WebKit Reporter: Daniel Bates <dbates>
Component: Tools / TestsAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Daniel Bates
Reported 2010-10-20 15:34:29 PDT
Currently, do-file-rename is hard coded to only work with SVN when renaming files that match the replacement criterion. Instead, we should abstract the SCM move/rename command into a common function in VCSUtils since this functionality is used by both do-file-rename and do-webcore-rename.
Attachments
Patch (3.61 KB, patch)
2010-10-20 15:46 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2010-10-20 15:46:03 PDT
Created attachment 71349 [details] Patch Add an SCM-independent move/rename function to VCSUtils.pm that can is used by both do-file-rename and do-webcore-rename.
Martin Robinson
Comment 2 2010-10-20 15:51:54 PDT
Comment on attachment 71349 [details] Patch Looks good!
Daniel Bates
Comment 3 2010-10-20 15:54:48 PDT
Comment on attachment 71349 [details] Patch Clearing flags on attachment: 71349 Committed r70187: <http://trac.webkit.org/changeset/70187>
Daniel Bates
Comment 4 2010-10-20 15:54:53 PDT
All reviewed patches have been landed. Closing bug.
Daniel Bates
Comment 5 2010-10-21 14:22:54 PDT
I inadvertently left out the line to export the function scmMoveOrRenameFile() in the patch. Committed fix in changeset 70264 <http://trac.webkit.org/changeset/70264>.
Note You need to log in before you can comment on or make changes to this bug.