Bug 48013

Summary:

[Qt] Add findAllSelectedElements and findFirstSelectedElement functions to QWebFrame

Product:

WebKit

Reporter:

Dawit A. <adawit>

Component:

WebKit Qt

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED INVALID

Severity:

Enhancement

CC:

benjamin

Priority:

Keywords:

Qt, QtTriaged

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
proposed patch	none
proposed patch [update #1]	none
proposed patch [update #2]	benjamin: review-

Dawit A.

Reported 2010-10-20 15:05:09 PDT

This enhancement is intended to make it possible to search for elements ONLY in the user-selected portions of a web page.

Attachments
proposed patch (18.98 KB, patch) 2010-10-20 15:18 PDT, Dawit A.	no flags	Details Formatted Diff Diff
proposed patch [update #1] (17.40 KB, patch) 2010-10-21 12:47 PDT, Dawit A.	no flags	Details Formatted Diff Diff
proposed patch [update #2] (17.39 KB, patch) 2010-10-22 09:42 PDT, Dawit A.	benjamin: review-	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Dawit A.

Comment 1 2010-10-20 15:18:41 PDT

Created attachment 71347 [details] proposed patch

Dawit A.

Comment 2 2010-10-21 12:47:45 PDT

Created attachment 71474 [details] proposed patch [update #1]

Dawit A.

Comment 3 2010-10-22 09:42:28 PDT

Created attachment 71570 [details] proposed patch [update #2] let see if this solves the patch apply failure...

Benjamin Poulain

Comment 4 2011-02-21 15:55:20 PST

I am really, really not a fan of the API. This is just abusing QWebElement, which is already causing us problems because it does not handle text. Personally, I think we should not try to solve selection before solving https://bugs.webkit.org/show_bug.cgi?id=31099 When we have a good way to access elements and text, then we can create a new class to handle selection.

Benjamin Poulain

Comment 5 2011-02-21 15:56:39 PST

Comment on attachment 71570 [details] proposed patch [update #2] I r- for now. I think this is the wrong solution to the problem. You can start the discussion on the mailing list.

Dawit A.

Comment 6 2011-02-21 17:11:05 PST

Yes, I actually meant to withdraw this request, but completely forgot about it. Besides the solution I came up with here being very ugly and hacky, QWebElement itself has more than few limitations and at least one severe bug in the underlying code (read: webkit) which has already forced me to stop using it in kdewebkit to parse for forms on a page. Anyhow, I will withdraw this request and close the ticket.

Note You need to log in before you can comment on or make changes to this bug.