Bug 48005

Summary: chromium_gpu port of new-run-webkit-tests must do Linux -> Win expectations fallback
Product: WebKit Reporter: Kenneth Russell <kbr>
Component: Tools / TestsAssignee: Kenneth Russell <kbr>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, eric, jamesr, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch jamesr: review+, kbr: commit-queue-

Kenneth Russell
Reported 2010-10-20 13:47:09 PDT
The normal Chromium port of new-run-webkit-tests, when run on Linux, searches first the Linux directory for test expectations and then the Windows directory. The chromium-gpu port needs to do the same within the scope of the chromium-gpu directories.
Attachments
Patch (1.43 KB, patch)
2010-10-20 13:48 PDT, Kenneth Russell 		jamesr: review+
kbr: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kenneth Russell
Comment 1 2010-10-20 13:48:39 PDT
Created attachment 71333 [details] Patch
James Robinson
Comment 2 2010-10-20 13:50:57 PDT
So on chromium linux with gpu it'll go: chromium-gpu-linux chromium-gpu-win chromium-gpu chromium-linux chromium-win chromium mac (alongside test) ?
Kenneth Russell
Comment 3 2010-10-20 13:53:51 PDT
(In reply to comment #2) > So on chromium linux with gpu it'll go: > > chromium-gpu-linux > chromium-gpu-win > chromium-gpu > chromium-linux > chromium-win > chromium > mac > (alongside test) > > ? Yes, that's right. Dirk and I discussed this last night and this is the intended and desired behavior.
Kenneth Russell
Comment 4 2010-10-20 13:54:57 PDT
Committed r70175: <http://trac.webkit.org/changeset/70175>
Dirk Pranke
Comment 5 2010-10-20 14:06:13 PDT
Comment on attachment 71333 [details] Patch change looks good to me, although I'm not a reviewer.
WebKit Review Bot
Comment 6 2010-10-20 14:36:08 PDT
http://trac.webkit.org/changeset/70175 might have broken SnowLeopard Intel Release (Tests) The following tests are not passing: http/tests/xmlhttprequest/origin-whitelisting-removal.html
Note You need to log in before you can comment on or make changes to this bug.