Summary: | No longer soft-link zlib | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | mitz | ||||||||
Component: | Platform | Assignee: | mitz | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | aroben, eric | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | PC | ||||||||||
OS: | Windows XP | ||||||||||
Attachments: |
|
Description
mitz
2010-10-20 13:40:32 PDT
Created attachment 71332 [details]
Remove Windows-speciific code to soft-link zlib
Comment on attachment 71332 [details]
Remove Windows-speciific code to soft-link zlib
Oops, need to actually hard-link it.
Created attachment 72195 [details]
Patch
Comment on attachment 72195 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=72195&action=review > WebKit2/win/WebKit2.vcproj:367 > /> > <Tool > Name="VCLinkerTool" > + AdditionalDependencies="zlib.lib" This should be added to WebKit2Common.vsprops instead. Sorry for leading you astray earlier! Created attachment 72197 [details]
Patch
Comment on attachment 72197 [details]
Patch
r=me
Attachment 72197 [details] was posted by a committer and has review+, assigning to Dan Bernstein for commit.
|