Bug 48004 - No longer soft-link zlib
Summary: No longer soft-link zlib
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: mitz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-20 13:40 PDT by mitz
Modified: 2010-11-10 14:15 PST (History)
2 users (show)

See Also:


Attachments
Remove Windows-speciific code to soft-link zlib (3.62 KB, patch)
2010-10-20 13:45 PDT, mitz
no flags Details | Formatted Diff | Diff
Patch (5.23 KB, patch)
2010-10-28 09:24 PDT, mitz
aroben: review-
Details | Formatted Diff | Diff
Patch (5.97 KB, patch)
2010-10-28 09:36 PDT, mitz
aroben: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2010-10-20 13:40:32 PDT
Patch forthcoming
Comment 1 mitz 2010-10-20 13:45:38 PDT
Created attachment 71332 [details]
Remove Windows-speciific code to soft-link zlib
Comment 2 mitz 2010-10-20 13:47:48 PDT
Comment on attachment 71332 [details]
Remove Windows-speciific code to soft-link zlib

Oops, need to actually hard-link it.
Comment 3 mitz 2010-10-28 09:24:50 PDT
Created attachment 72195 [details]
Patch
Comment 4 Adam Roben (:aroben) 2010-10-28 09:28:06 PDT
Comment on attachment 72195 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=72195&action=review

> WebKit2/win/WebKit2.vcproj:367
>  			/>
>  			<Tool
>  				Name="VCLinkerTool"
> +				AdditionalDependencies="zlib.lib"

This should be added to WebKit2Common.vsprops instead. Sorry for leading you astray earlier!
Comment 5 mitz 2010-10-28 09:36:18 PDT
Created attachment 72197 [details]
Patch
Comment 6 Adam Roben (:aroben) 2010-10-28 09:51:52 PDT
Comment on attachment 72197 [details]
Patch

r=me
Comment 7 mitz 2010-10-28 09:54:05 PDT
Fixed in <http://trac.webkit.org/projects/webkit/changeset/70785>.
Comment 8 Eric Seidel (no email) 2010-11-10 14:14:51 PST
Attachment 72197 [details] was posted by a committer and has review+, assigning to Dan Bernstein for commit.