Bug 47979

Summary: Do not have two different asCell APIs in JSValue
Product: WebKit Reporter: Xan Lopez <xan.lopez>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
ascell.diff
none
ascell.diff
none
ascell.diff
none
ascell.diff
none
ascell.diff none

Description Xan Lopez 2010-10-20 05:47:29 PDT 
We have both JSCell* JSValue::asCell() and JSCell* asCell(JSValue value). Attached patch gets rid of the latter as suggested by FIXME.
Comment 1 Xan Lopez 2010-10-20 05:49:23 PDT 
Created attachment 71277 [details]
ascell.diff
Comment 2 WebKit Review Bot 2010-10-20 05:53:32 PDT 
Attachment 71277 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
JavaScriptCore/jit/JITStubs.cpp:2909:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
JavaScriptCore/jit/JITStubs.cpp:2915:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Total errors found: 2 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Xan Lopez 2010-10-20 06:02:49 PDT 
Created attachment 71279 [details]
ascell.diff

Fix style warnings. They were already there, but since we are touching the code...
Comment 4 Xan Lopez 2010-10-20 06:25:06 PDT 
Created attachment 71281 [details]
ascell.diff

Fix interpreter bits.
Comment 5 Xan Lopez 2010-10-20 06:51:04 PDT 
Created attachment 71288 [details]
ascell.diff
Comment 6 Xan Lopez 2010-10-20 07:45:41 PDT 
Created attachment 71293 [details]
ascell.diff

Trying to upload the correct patch...
Comment 7 Oliver Hunt 2010-10-27 13:30:39 PDT 
Comment on attachment 71293 [details]
ascell.diff

r=me
Comment 8 Xan Lopez 2010-10-28 00:02:01 PDT 
Comment on attachment 71293 [details]
ascell.diff

Landed as r70749.
Comment 9 Xan Lopez 2010-10-28 00:02:14 PDT 
Closing bug.