| Summary: | Rename SVGAnimatedProperty* -> DeprecatedSVGAnimatedProperty* | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Nikolas Zimmermann <zimmermann> | ||||||
| Component: | SVG | Assignee: | Nikolas Zimmermann <zimmermann> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | abarth, caseq, eric, krit, mdelaney7, webkit.review.bot, zimmermann | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | PC | ||||||||
| OS: | OS X 10.5 | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 47905 | ||||||||
| Attachments: |
|
||||||||
|
Description
Nikolas Zimmermann
2010-10-20 00:31:29 PDT
Created attachment 71259 [details]
Patch
Created attachment 71263 [details]
Patch v2
Let's see if it applies this time *sigh*. I just reverted the SVGAnimatedPropertySynchronizer move, and started again by doing:
mkdir properties; svn add properties; svn mv SVGAnimatedPropertySynchronizer.h properties;
Not sure why it did not work before...
Landed qt/gtk/win build fix (missing svg/property include directory) in r70136. Fix Qt/WebKit2 build in r70138. (In reply to comment #5) > Fix efl build in r70139. WebCore builds. Fix WebKit efl build in r70142. This apparently broke clobbered build on win due to DeprecatedSVGAnimatedProperty.h:25:#include "SVGAnimatedPropertySynchronizer.h" The latter include moved under properties subdir, which is not copied to WebKitBuild/include/WebCore. You may want to update WebKit/WebCore/WebCore.vcproj/copyForwardingHeaders.cmd The incremental build apparently works due to https://webkit.org/b/46638 (In reply to comment #7) > This apparently broke clobbered build on win due to > DeprecatedSVGAnimatedProperty.h:25:#include "SVGAnimatedPropertySynchronizer.h" > > The latter include moved under properties subdir, which is not copied to WebKitBuild/include/WebCore. You may want to update > WebKit/WebCore/WebCore.vcproj/copyForwardingHeaders.cmd > > The incremental build apparently works due to https://webkit.org/b/46638 Thanks for the note, landed a fix in r70168. http://trac.webkit.org/changeset/70168 might have broken GTK Linux 64-bit Debug The following tests are not passing: fast/backgrounds/repeat/negative-offset-repeat-transformed.html fast/borders/border-image-rotate-transform.html fast/borders/border-image-scale-transform.html fast/transforms/scrollIntoView-transformed.html transforms/2d/hindi-rotated.html |