Bug 47973

Summary: Rename SVGAnimatedProperty* -> DeprecatedSVGAnimatedProperty*
Product: WebKit Reporter: Nikolas Zimmermann <zimmermann>
Component: SVGAssignee: Nikolas Zimmermann <zimmermann>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, caseq, eric, krit, mdelaney7, webkit.review.bot, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 47905    
Attachments:
Description Flags
Patch
none
Patch v2 aroben: review+

Nikolas Zimmermann
Reported 2010-10-20 00:31:29 PDT
To prepare fixing bug 47905, mark the existing animated property concept deprecated.
Attachments
Patch (102.53 KB, patch)
2010-10-20 00:39 PDT, Nikolas Zimmermann 		no flags
DetailsFormatted DiffDiff
Patch v2 (102.51 KB, patch)
2010-10-20 01:07 PDT, Nikolas Zimmermann 		aroben: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Nikolas Zimmermann
Comment 1 2010-10-20 00:39:17 PDT
Created attachment 71259 [details] Patch
Nikolas Zimmermann
Comment 2 2010-10-20 01:07:58 PDT
Created attachment 71263 [details] Patch v2 Let's see if it applies this time *sigh*. I just reverted the SVGAnimatedPropertySynchronizer move, and started again by doing: mkdir properties; svn add properties; svn mv SVGAnimatedPropertySynchronizer.h properties; Not sure why it did not work before...
Nikolas Zimmermann
Comment 3 2010-10-20 01:33:20 PDT
Thanks. Landed in r70135.
Nikolas Zimmermann
Comment 4 2010-10-20 02:15:51 PDT
Landed qt/gtk/win build fix (missing svg/property include directory) in r70136. Fix Qt/WebKit2 build in r70138.
Nikolas Zimmermann
Comment 5 2010-10-20 02:19:20 PDT
Fix efl build in r70139.
Nikolas Zimmermann
Comment 6 2010-10-20 02:44:05 PDT
(In reply to comment #5) > Fix efl build in r70139. WebCore builds. Fix WebKit efl build in r70142.
Andrey Kosyakov
Comment 7 2010-10-20 10:47:23 PDT
This apparently broke clobbered build on win due to DeprecatedSVGAnimatedProperty.h:25:#include "SVGAnimatedPropertySynchronizer.h" The latter include moved under properties subdir, which is not copied to WebKitBuild/include/WebCore. You may want to update WebKit/WebCore/WebCore.vcproj/copyForwardingHeaders.cmd The incremental build apparently works due to https://webkit.org/b/46638
Nikolas Zimmermann
Comment 8 2010-10-20 13:28:52 PDT
(In reply to comment #7) > This apparently broke clobbered build on win due to > DeprecatedSVGAnimatedProperty.h:25:#include "SVGAnimatedPropertySynchronizer.h" > > The latter include moved under properties subdir, which is not copied to WebKitBuild/include/WebCore. You may want to update > WebKit/WebCore/WebCore.vcproj/copyForwardingHeaders.cmd > > The incremental build apparently works due to https://webkit.org/b/46638 Thanks for the note, landed a fix in r70168.
WebKit Review Bot
Comment 9 2010-10-20 14:41:13 PDT
http://trac.webkit.org/changeset/70168 might have broken GTK Linux 64-bit Debug The following tests are not passing: fast/backgrounds/repeat/negative-offset-repeat-transformed.html fast/borders/border-image-rotate-transform.html fast/borders/border-image-scale-transform.html fast/transforms/scrollIntoView-transformed.html transforms/2d/hindi-rotated.html
Note You need to log in before you can comment on or make changes to this bug.