Bug 47960

Summary: ASSERTION FAILURE: !m_adoptionIsRequired for the WebFrame under the InjectedBundlePageLoaderClient::didClearWindowObjectForFrame callback
Product: WebKit Reporter: Jessie Berlin <jberlin>
Component: WebKit2Assignee: Jessie Berlin <jberlin>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, aroben, eric, jberlin, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Move initializing the coreFrame into the WebFrame create method and out of the WebFrame constructor none

Jessie Berlin
Reported 2010-10-19 18:04:22 PDT
frame->init() in the WebFrame constructor causes the InjectedBundlePageLoaderClient::didClearWindowObjectForFrame callback to be called with a reference to the WebFrame (at which point the WebFrame has not yet been adopted). We should fix this by moving the frame->init() call into the WebFrame::create method.
Attachments
Move initializing the coreFrame into the WebFrame create method and out of the WebFrame constructor (1.90 KB, patch)
2010-10-19 18:11 PDT, Jessie Berlin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jessie Berlin
Comment 1 2010-10-19 18:11:26 PDT
Created attachment 71238 [details] Move initializing the coreFrame into the WebFrame create method and out of the WebFrame constructor
Geoffrey Garen
Comment 2 2010-10-20 08:21:16 PDT
Comment on attachment 71238 [details] Move initializing the coreFrame into the WebFrame create method and out of the WebFrame constructor r=me
Jessie Berlin
Comment 3 2010-10-20 08:32:23 PDT
Comment on attachment 71238 [details] Move initializing the coreFrame into the WebFrame create method and out of the WebFrame constructor Committed in r70148 http://trac.webkit.org/changeset/70148
WebKit Review Bot
Comment 4 2010-10-20 09:26:38 PDT
http://trac.webkit.org/changeset/70148 might have broken Leopard Intel Release (Tests) The following tests are not passing: fast/workers/storage/interrupt-database-sync.html
Jessie Berlin
Comment 5 2010-10-20 09:34:52 PDT
(In reply to comment #4) > http://trac.webkit.org/changeset/70148 might have broken Leopard Intel Release (Tests) > The following tests are not passing: > fast/workers/storage/interrupt-database-sync.html Pretty unlikely, as we don't build WebKit2 stuff on Leopard.
WebKit Review Bot
Comment 6 2010-10-20 14:35:50 PDT
http://trac.webkit.org/changeset/70173 might have broken SnowLeopard Intel Release (Tests) The following tests are not passing: http/tests/xmlhttprequest/origin-whitelisting-removal.html
Note You need to log in before you can comment on or make changes to this bug.