Bug 47933

Summary: navigator.language doesn't work in WebKit2
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: WebKit2Assignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal Keywords: InRadar
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
proposed patch andersca: review+

Alexey Proskuryakov
Reported 2010-10-19 14:47:58 PDT
It should!
Attachments
proposed patch (62.79 KB, patch)
2010-10-19 15:15 PDT, Alexey Proskuryakov 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2010-10-19 14:49:28 PDT
Mac is somewhat special in that there is a way to override language per application (or even per an instance of an application). This means that we should only be looking at the language in UI process.
Alexey Proskuryakov
Comment 2 2010-10-19 14:49:42 PDT
<rdar://problem/8494337>
Alexey Proskuryakov
Comment 3 2010-10-19 15:15:48 PDT
Created attachment 71208 [details] proposed patch
Anders Carlsson
Comment 4 2010-10-19 15:18:56 PDT
Comment on attachment 71208 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=71208&action=review > WebCore/platform/mac/Language.mm:95 > + preferredLanguageCode = [@"en" retain]; No need to retain a constant string.
Alexey Proskuryakov
Comment 5 2010-10-19 15:29:22 PDT
Committed <http://trac.webkit.org/changeset/70095>.
Note You need to log in before you can comment on or make changes to this bug.