Summary: | Add DirectX SDK to Installing Developer Tools web page | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jenn Braithwaite <jennb> | ||||||
Component: | WebKit Website | Assignee: | Jenn Braithwaite <jennb> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | aroben, bweinstein, cmarrin, commit-queue, eric | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | OS X 10.5 | ||||||||
Attachments: |
|
Description
Jenn Braithwaite
2010-10-19 10:23:56 PDT
Created attachment 71182 [details]
patch
Comment on attachment 71182 [details]
patch
OK.
CCing the windows folks. Comment on attachment 71182 [details] patch Rejecting patch 71182 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'land-attachment', '--force-clean', '--ignore-builders', '--quiet', '--non-interactive', '--parent-command=commit-queue', 71182]" exit_code: 2 Last 500 characters of output: ?id=71182&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=47911&ctype=xml Processing 1 patch from 1 bug. Cleaning working directory Updating working directory Processing patch 71182 from bug 47911. Found no modified ChangeLogs, cannot create a commit message. All changes require a ChangeLog. See: http://webkit.org/coding/contributing.html Found no modified ChangeLogs, cannot create a commit message. All changes require a ChangeLog. See: http://webkit.org/coding/contributing.html Full output: http://queues.webkit.org/results/4553004 Created attachment 71206 [details]
updated patch with ChangeLog
Forgot to include ChangeLog in the previous patch.
Comment on attachment 71206 [details] updated patch with ChangeLog View in context: https://bugs.webkit.org/attachment.cgi?id=71206&action=review > WebKitSite/building/tools.html:63 > +<p> Verify MSVC|Tools|Options|Projects and Solutions|VC++ Directories has Include: <code>$(DXSDK_DIR)include</code> and Lib: <code>$(DXSDK_DIR)lib</code> 1) $(DXSDK_DIR)lib isn't correct. It should be $(DXSDK_DIR)lib/x86. 2) This shouldn't be necessary. Our projects add these to the include/lib paths for you. But thanks for updating the instructions! Comment on attachment 71182 [details] patch Cleared Eric Seidel's review+ from obsolete attachment 71182 [details] so that this bug does not appear in http://webkit.org/pending-commit. Comment on attachment 71206 [details] updated patch with ChangeLog Clearing flags on attachment: 71206 Committed r70121: <http://trac.webkit.org/changeset/70121> All reviewed patches have been landed. Closing bug. |