Bug 47899 – Multiple selection support for <select multiple> popups.

• Component: WebKit2
• Status: RESOLVED LATER

[Luiz Agostini]

Add multiple selection popup widget support (<select multiple> elements) to WebKit2.

<select multiple> elements may be rendered as menu lists if ENABLE_NO_LISTBOX_RENDERING is used. Those multiple menu lists need multiple selection capable popups.

[Luiz Agostini]

Created attachment 71159 [details]
patch

[Luiz Agostini]

Created attachment 71168 [details]
patch

[Kenneth Rohde Christiansen]

Hi Sam, I saw you and Luiz' talk on IRC and it seems that this patch is not even being considered for inclusion, which I think is sad and bad for our cooperation.

Now that Luiz worked hard on this and is doing his best trying to cooperate with you, I think you at least owe him a bit of feedback on the approach of the patch.

Luiz did large parts of refactoring the web popup code in WebCore before, and it would be good to discuss the right approach of making this accessible to WebKit2 in an open manner so that it serves both of our teams - or at least give Luiz time to look at your refactorings before committing it to trunk, though the former would be preferable.

[Antti Koivisto]

Kenneth,

I don't think Sam owes anything to anyone. 

If there is a major refactoring going on I can see that it does not make sense to disrupt that with an obscure feature like this. WebKit2 is not yet stable and people who are actually mostly developing it should be allowed to do their job without being hindered.

There is a gitorious branch for the very purpose of doing Qt WebKit2 work while avoiding disruptions to either direction.

[Kenneth Rohde Christiansen]

(In reply to comment #4)
> Kenneth,
> 
> I don't think Sam owes anything to anyone. 
> 
> If there is a major refactoring going on I can see that it does not make sense to disrupt that with an obscure feature like this. WebKit2 is not yet stable and people who are actually mostly developing it should be allowed to do their job without being hindered.
> 
> There is a gitorious branch for the very purpose of doing Qt WebKit2 work while avoiding disruptions to either direction.

Hey Antti, I understand that. This isn't mean as any attack on anyone, but I just would like everyone working on the project to be happy, and it seems that Luiz was seriously disappointed.

The thing was that Luiz opened a bug before any code dealing with web popups was implemented as he wanted to work on that and to gather feed back on the best way to implement it. Sam was also cc'ed to this bug and there were some discussion.

Then suddenly code was landed to trunk without any heads-up in the other bug, so Luiz talked to Sam and as far as I understand they decided that he could make a patch on top of the other one, which he then did. It then seems that the patch was just ignored due to refactorings coming up.

I'm pretty sure that was not done to piss of Luiz in any way, but it might have come up that way - which is the reason for my last comment.

[Luiz Agostini]

I actually have been working in this feature and in fact some of my work have been lost. But this not a problem, we write code every day, some code may be lost. No problem.

No one owes me nothing indeed. I do not want to hinder people who are actually developing WebKit2. I actually want it to be ready as soon as possible.

I do not expect to receive any feedback for this patch nor for bug 47256.

I am closing this bug.

[Eric Seidel (no email)]

Comment on attachment 71168 [details]
patch

Cleared review? from attachment 71168 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).