Bug 47887

Summary: Remove private: access level directive from WTF_MAKE_FAST_ALLOCATED macro
Product: WebKit Reporter: Zoltan Horvath <zoltan>
Component: Web Template FrameworkAssignee: Zoltan Horvath <zoltan>
Status: RESOLVED INVALID    
Severity: Normal CC: andersca, darin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Bug Depends on: 42998    
Bug Blocks:    
Attachments:
Description Flags
proposed patch none

Zoltan Horvath
Reported 2010-10-19 00:52:02 PDT
We should remove private directive from the end of the WTF_MAKE_FAST_ALLOCATED macro, because it can causes problems with structs. This solution isn't nice: struct a { WTF_MAKE_FAST_ALLOCATED public: int x; } Other way is to put the macro to the end of the struct: struct a { int x; WTF_MAKE_FAST_ALLOCATED } Or we can simply remove "private:" from the end of the macro. Almost every class contains access level directives explicitly, so removing shouldn't cause much problems.
Attachments
proposed patch (1.08 KB, patch)
2010-10-19 00:53 PDT, Zoltan Horvath
no flags
Zoltan Horvath
Comment 1 2010-10-19 00:53:22 PDT
Created attachment 71139 [details] proposed patch
Zoltan Horvath
Comment 2 2010-11-22 01:29:48 PST
Comment on attachment 71139 [details] proposed patch I've chosen the first solution since it is unambiguous. Closing as invalid.
Note You need to log in before you can comment on or make changes to this bug.