Bug 47875

Summary: Regression in run_webkit_tests_unittest from r70017
Product: WebKit Reporter: Kenneth Russell <kbr>
Component: Tools / TestsAssignee: Kenneth Russell <kbr>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, eric, jamesr, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch tony: review+, kbr: commit-queue-

Kenneth Russell
Reported 2010-10-18 20:07:42 PDT
The change to WebKitTools/Scripts/webkitpy/layout_tests/port/base.py in r70017 introduced a regression in webkitpy/layout_tests/run_webkit_tests_unittest.py because the mocked file open routine is overspecialized for the file mode.
Attachments
Patch (1.28 KB, patch)
2010-10-18 20:13 PDT, Kenneth Russell 		tony: review+
kbr: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kenneth Russell
Comment 1 2010-10-18 20:13:33 PDT
Created attachment 71124 [details] Patch Ran test-webkit-scripts (which I didn't know about before) to verify.
Tony Chang
Comment 2 2010-10-18 20:21:03 PDT
Comment on attachment 71124 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=71124&action=review > WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:267 > + if name.find("-expected.") != -1 and mode.find("w") != -1: Nit: "w" in mode
Kenneth Russell
Comment 3 2010-10-18 20:22:22 PDT
Committed r70021: <http://trac.webkit.org/changeset/70021>
WebKit Review Bot
Comment 4 2010-10-18 21:49:17 PDT
http://trac.webkit.org/changeset/70021 might have broken SnowLeopard Intel Release (Tests)
Note You need to log in before you can comment on or make changes to this bug.