Bug 47875

Summary: Regression in run_webkit_tests_unittest from r70017
Product: WebKit Reporter: Kenneth Russell <kbr>
Component: Tools / TestsAssignee: Kenneth Russell <kbr>
Severity: Normal CC: abarth, dpranke, eric, jamesr, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Description Flags
Patch tony: review+, kbr: commit-queue-

Description Kenneth Russell 2010-10-18 20:07:42 PDT
The change to WebKitTools/Scripts/webkitpy/layout_tests/port/base.py in r70017 introduced a regression in webkitpy/layout_tests/run_webkit_tests_unittest.py because the mocked file open routine is overspecialized for the file mode.
Comment 1 Kenneth Russell 2010-10-18 20:13:33 PDT
Created attachment 71124 [details]

Ran test-webkit-scripts (which I didn't know about before) to verify.
Comment 2 Tony Chang 2010-10-18 20:21:03 PDT
Comment on attachment 71124 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=71124&action=review

> WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:267
> +        if name.find("-expected.") != -1 and mode.find("w") != -1:

Nit: "w" in mode
Comment 3 Kenneth Russell 2010-10-18 20:22:22 PDT
Committed r70021: <http://trac.webkit.org/changeset/70021>
Comment 4 WebKit Review Bot 2010-10-18 21:49:17 PDT
http://trac.webkit.org/changeset/70021 might have broken SnowLeopard Intel Release (Tests)