Bug 47875 - Regression in run_webkit_tests_unittest from r70017
Summary: Regression in run_webkit_tests_unittest from r70017
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Kenneth Russell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-18 20:07 PDT by Kenneth Russell
Modified: 2010-10-18 21:49 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.28 KB, patch)
2010-10-18 20:13 PDT, Kenneth Russell 		tony: review+
kbr: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Russell 2010-10-18 20:07:42 PDT 
The change to WebKitTools/Scripts/webkitpy/layout_tests/port/base.py in r70017 introduced a regression in webkitpy/layout_tests/run_webkit_tests_unittest.py because the mocked file open routine is overspecialized for the file mode.
Comment 1 Kenneth Russell 2010-10-18 20:13:33 PDT 
Created attachment 71124 [details]
Patch

Ran test-webkit-scripts (which I didn't know about before) to verify.
Comment 2 Tony Chang 2010-10-18 20:21:03 PDT 
Comment on attachment 71124 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=71124&action=review

> WebKitTools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:267
> +        if name.find("-expected.") != -1 and mode.find("w") != -1:

Nit: "w" in mode
Comment 3 Kenneth Russell 2010-10-18 20:22:22 PDT 
Committed r70021: <http://trac.webkit.org/changeset/70021>
Comment 4 WebKit Review Bot 2010-10-18 21:49:17 PDT 
http://trac.webkit.org/changeset/70021 might have broken SnowLeopard Intel Release (Tests)