Bug 47871

Summary: Need to include WKErrorRef in the WKPageDidFail... functions
Product: WebKit Reporter: Sam Weinig <sam>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-ews, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
mitz: review+
Part two. andersca: review+

Sam Weinig
Reported 2010-10-18 19:01:51 PDT
We need to fix the FIXME in WKPage.h and add WKErrorRef parameters to the WKPageDidFail... functions.
Attachments
Patch (34.50 KB, patch)
2010-10-18 19:05 PDT, Sam Weinig 		mitz: review+
DetailsFormatted DiffDiff
Part two. (20.78 KB, patch)
2010-10-19 10:05 PDT, Sam Weinig 		andersca: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2010-10-18 19:02:05 PDT
<rdar://problem/8564110>
Sam Weinig
Comment 2 2010-10-18 19:05:04 PDT
Created attachment 71114 [details] Patch
Early Warning System Bot
Comment 3 2010-10-18 19:13:41 PDT
Attachment 71114 [details] did not build on qt: Build output: http://queues.webkit.org/results/4423076
Sam Weinig
Comment 4 2010-10-19 10:05:47 PDT
Created attachment 71179 [details] Part two.
WebKit Review Bot
Comment 5 2010-10-19 10:09:28 PDT
Attachment 71179 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit2/Shared/WebError.cpp:27: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 1 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sam Weinig
Comment 6 2010-10-19 10:16:21 PDT
Part 1 landed in http://trac.webkit.org/changeset/70062. Part 2 landed in http://trac.webkit.org/changeset/70066.
Note You need to log in before you can comment on or make changes to this bug.