|Summary:||Implement webkit-patch suggest-reviewers|
|Product:||WebKit||Reporter:||Adam Barth <abarth>|
|Component:||New Bugs||Assignee:||Adam Barth <abarth>|
|Severity:||Normal||CC:||commit-queue, eric, ojan|
|Version:||528+ (Nightly build)|
|OS:||OS X 10.5|
Description Adam Barth 2010-10-18 17:56:44 PDT
Implement webkit-patch suggest-reviewers
Comment 2 Eric Seidel (no email) 2010-10-18 18:08:04 PDT
Comment on attachment 71109 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=71109&action=review Looks good to me. I'm glad you beat me to it. Nicely done. :) > WebKitTools/Scripts/webkitpy/common/checkout/api.py:118 > + def suggested_reviewers(self, git_commit): I guess I figured Checkout would have had a more generic API (like the CommitInfos for the last N revisions), but OK.
Comment 3 WebKit Commit Bot 2010-10-18 18:28:47 PDT
Comment on attachment 71109 [details] Patch Rejecting patch 71109 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'apply-attachment', '--force-clean', '--non-interactive', '--quiet', 71109]" exit_code: 2 Cleaning working directory Updating working directory Logging in as firstname.lastname@example.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=71109&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=47866&ctype=xml Processing 1 patch from 1 bug. Processing patch 71109 from bug 47866. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Eric Seidel', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/4414082
Comment 4 Adam Barth 2010-10-18 18:47:31 PDT
Comment on attachment 71109 [details] Patch Oh noes! Darn you commit-cluster!
Comment 5 WebKit Commit Bot 2010-10-18 19:44:41 PDT
Comment on attachment 71109 [details] Patch Clearing flags on attachment: 71109 Committed r70020: <http://trac.webkit.org/changeset/70020>
Comment 6 WebKit Commit Bot 2010-10-18 19:44:47 PDT
All reviewed patches have been landed. Closing bug.
Comment 7 Ojan Vafai 2010-10-19 07:59:55 PDT
This is a great start. I was imagining that the way we'd implement this was to look at the annotate for the file at the lines modified and use those as the reviewers. That's what I do when I do it manually. WDYT?
Comment 8 Eric Seidel (no email) 2010-10-19 08:05:43 PDT
(In reply to comment #7) > This is a great start. I was imagining that the way we'd implement this was to look at the annotate for the file at the lines modified and use those as the reviewers. That's what I do when I do it manually. WDYT? Yup. We could do that. That's what I originally started to do (and have a half-patch for). But this solution is much simpler and gets us 90% of the way there it seems. IF we're going to look at the individual lines, either we have to create a diff and use DiffParser, or we have to find some way to get modified line ranges out of git/svn w/o creating a patch. The annotate step after that is easy.