Bug 47865
| Summary: | Remove VisiblePosition from RenderTextControl | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> |
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Critical | CC: | adele, darin, eric, jamesr, leviw, simon.fraser, tkent |
| Priority: | P1 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
| Bug Depends on: | 47870, 64118, 64133, 64134 | ||
| Bug Blocks: | |||
Ryosuke Niwa
RenderTextControl currently has many functions that instantiate VisiblePosition but this may cause layout and destroy the RenderTextControl itself. We must remove this dependency as soon as possible.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ryosuke Niwa
Now, the only member function of RenderTextControl that uses VisiblePosition is visiblePositionForIndex, which is inherited from RenderObject. Since removing visiblePositionForIndex from RenderTextControl requires removing it from RenderObject, I consider this to be beyond the scope of this bug.