Bug 47853

Summary: context-attributes-etc layout test should test against undefined, not null
Product: WebKit Reporter: Adrienne Walker <enne>
Component: WebGLAssignee: Adrienne Walker <enne>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, enne, eric, kbr, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on: 47697    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Adrienne Walker
Reported 2010-10-18 14:53:52 PDT
The LayoutTests/fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html test creates several contexts and then gets their creation attributes and tests that all the named attributes exist. However, it is testing against null instead of undefined. This should be fixed by adding this function to js-test-pre.js and pushing the new test and the js-test-pre.js file to the Khronos repository. See: https://bugs.webkit.org/show_bug.cgi?id=47697 for more discussion.
Attachments
Patch (12.59 KB, patch)
2010-10-28 10:15 PDT, Adrienne Walker 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adrienne Walker
Comment 1 2010-10-28 10:15:58 PDT
Created attachment 72202 [details] Patch
Adrienne Walker
Comment 2 2010-10-28 10:17:24 PDT
This change has already been pushed into the Khronos repository. Additionally, the only test that needed to be changed was the window-property-descriptors expectations. The other tests mentioned in bug 47697 did not appear to be affected, both from running the tests directly but also from inspection.
Kenneth Russell
Comment 3 2010-10-28 11:46:43 PDT
Comment on attachment 72202 [details] Patch Looks good. I'm assuming you ran all of the layout tests affected by the addition of shouldBeDefined.
WebKit Commit Bot
Comment 4 2010-10-28 12:05:53 PDT
Comment on attachment 72202 [details] Patch Clearing flags on attachment: 72202 Committed r70794: <http://trac.webkit.org/changeset/70794>
WebKit Commit Bot
Comment 5 2010-10-28 12:05:58 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 6 2010-10-28 12:35:06 PDT
http://trac.webkit.org/changeset/70794 might have broken Qt Linux Release The following tests are not passing: fast/dom/Window/window-property-descriptors.html
Adrienne Walker
Comment 7 2010-10-28 14:12:33 PDT
(In reply to comment #6) > http://trac.webkit.org/changeset/70794 might have broken Qt Linux Release > The following tests are not passing: > fast/dom/Window/window-property-descriptors.html Filed https://bugs.webkit.org/show_bug.cgi?id=48564 to fix this test.
Note You need to log in before you can comment on or make changes to this bug.