Summary: | context-attributes-etc layout test should test against undefined, not null | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adrienne Walker <enne> | ||||
Component: | WebGL | Assignee: | Adrienne Walker <enne> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, commit-queue, enne, eric, kbr, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
Bug Depends on: | 47697 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Adrienne Walker
2010-10-18 14:53:52 PDT
Created attachment 72202 [details]
Patch
This change has already been pushed into the Khronos repository. Additionally, the only test that needed to be changed was the window-property-descriptors expectations. The other tests mentioned in bug 47697 did not appear to be affected, both from running the tests directly but also from inspection. Comment on attachment 72202 [details]
Patch
Looks good. I'm assuming you ran all of the layout tests affected by the addition of shouldBeDefined.
Comment on attachment 72202 [details] Patch Clearing flags on attachment: 72202 Committed r70794: <http://trac.webkit.org/changeset/70794> All reviewed patches have been landed. Closing bug. http://trac.webkit.org/changeset/70794 might have broken Qt Linux Release The following tests are not passing: fast/dom/Window/window-property-descriptors.html (In reply to comment #6) > http://trac.webkit.org/changeset/70794 might have broken Qt Linux Release > The following tests are not passing: > fast/dom/Window/window-property-descriptors.html Filed https://bugs.webkit.org/show_bug.cgi?id=48564 to fix this test. |