Bug 47840

Summary: Add matchCountDidChange callback
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch darin: review+

Description Anders Carlsson 2010-10-18 11:30:32 PDT
Add matchCountDidChange callback
Comment 1 Anders Carlsson 2010-10-18 11:33:28 PDT
Created attachment 71065 [details]
Patch
Comment 2 Darin Adler 2010-10-18 11:34:50 PDT
Comment on attachment 71065 [details]
Patch

Side thought, not just about this patch: I’m not sure that a single boolean for case sensitivity is the right set of options for text finding. Since Safari only uses “case insensitive false” mode, the “case insensitive true” mode is for future use. Might we want some other searching modes for future use?
Comment 3 WebKit Review Bot 2010-10-18 11:35:23 PDT
Attachment 71065 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/UIProcess/API/C/WKPage.h:174:  Extra space between WKPageMatchCountDidChangeCallback and matchCountDidChange  [whitespace/declaration] [3]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Anders Carlsson 2010-10-18 11:47:32 PDT
Committed r69978: <http://trac.webkit.org/changeset/69978>
Comment 5 WebKit Review Bot 2010-10-18 12:36:41 PDT
http://trac.webkit.org/changeset/69978 might have broken Leopard Intel Debug (Tests)