Bug 47827

Summary: Web Inspector: disable private browsing for inspector
Product: WebKit Reporter: Pavel Podivilov <podivilov>
Component: Web Inspector (Deprecated)Assignee: Pavel Podivilov <podivilov>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, apavlov, bweinstein, eric, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch. timothy: review+, podivilov: commit-queue-

Description Pavel Podivilov 2010-10-18 09:25:54 PDT
Currently private browsing is enabled for inspector which makes localStorage inaccessible.
Comment says it's done to keep inspector out of history, but even with private browsing disabled, inspector don't appear in history. Debugging safari showed that inspector's WebView doesn't have history delegate, but I'm not sure because
history delegate is assigned in private safari code.

Joseph, could you please check if inspector doesn't have history delegate and thus private browsing isn't needed for inspector?
Comment 1 Pavel Podivilov 2010-10-18 09:28:44 PDT
Created attachment 71046 [details]
Patch.
Comment 2 Joseph Pecoraro 2010-10-18 09:41:52 PDT
Timothy would be more likely to know. I'll see what I can find.
Comment 3 Joseph Pecoraro 2010-10-18 09:45:33 PDT
By the way, your patch should remove the comment if it is no longer true. =)
Comment 4 Timothy Hatcher 2010-10-18 09:50:06 PDT
Comment on attachment 71046 [details]
Patch.

I do think this is correct now, since we have the history delegate concept and there isn't one hooked up to the Inspector. Assuming you tested and didn't see it show up in Safari's History menu.
Comment 5 Pavel Podivilov 2010-10-18 09:58:03 PDT
Comment on attachment 71046 [details]
Patch.

cq- to address Joseph's comment.
Comment 6 Pavel Podivilov 2010-10-18 10:22:23 PDT
Committed r69969: <http://trac.webkit.org/changeset/69969>
Comment 7 WebKit Review Bot 2010-10-18 11:06:22 PDT
http://trac.webkit.org/changeset/69969 might have broken Qt Windows 32-bit Release