[GTK] Tests LayoutTests/fast/encoding/utf-32* fail when using glib unicode

• Component: WebKitGTK
• Status: RESOLVED FIXED

[Carlos Garcia Campos]

When webkit is built with glib unicode instead of icu tests utf-32-big-endian-bom, utf-32-big-endian-nobom, utf-32-little-endian-bom and utf-32-little-endian-nobom under LayoutTests/fast/encoding fail because TextCodecGtk doesn't register UTF-32 encoding names.

[Carlos Garcia Campos]

Created attachment 71011 [details]
Patch

[WebKit Review Bot]

Attachment 71011 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebCore/platform/text/gtk/TextCodecGtk.h:72:  m_codecAliases_UTF_32 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/text/gtk/TextCodecGtk.h:73:  m_codecAliases_UTF_32BE is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/text/gtk/TextCodecGtk.h:74:  m_codecAliases_UTF_32LE is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/text/gtk/TextCodecGtk.cpp:59:  TextCodecGtk::m_codecAliases_UTF_8 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/text/gtk/TextCodecGtk.cpp:60:  TextCodecGtk::m_codecAliases_UTF_32 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/text/gtk/TextCodecGtk.cpp:61:  TextCodecGtk::m_codecAliases_UTF_32BE is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
WebCore/platform/text/gtk/TextCodecGtk.cpp:62:  TextCodecGtk::m_codecAliases_UTF_32LE is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 7 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Martin Robinson]

Comment on attachment 71011 [details]
Patch

Looks good, but please fix all the variable names (e.g. m_codecAliases_UTF_8 --> m_codecAliasesUTF8). Thanks.

[Carlos Garcia Campos]

Created attachment 71407 [details]
Updated patch for current git master

[Martin Robinson]

Comment on attachment 71407 [details]
Updated patch for current git master

Much nicer!

[WebKit Commit Bot]

Comment on attachment 71407 [details]
Updated patch for current git master

Clearing flags on attachment: 71407

Committed r70227: <http://trac.webkit.org/changeset/70227>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.