Bug 47795

Summary: Add a test to nodesFromRect involving links and text nodes
Product: WebKit Reporter: Antonio Gomes <tonikitoo>
Component: Tools / TestsAssignee: Antonio Gomes <tonikitoo>
Status: RESOLVED FIXED    
Severity: Normal CC: kenneth, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
(committed r70058, r=kenneth) patch v1 - Improves the test coverage for nodesFromRect. none

Antonio Gomes
Reported 2010-10-17 22:38:12 PDT
...
Attachments
(committed r70058, r=kenneth) patch v1 - Improves the test coverage for nodesFromRect. (5.38 KB, patch)
2010-10-18 21:40 PDT, Antonio Gomes 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antonio Gomes
Comment 1 2010-10-18 21:40:35 PDT
Created attachment 71129 [details] (committed r70058, r=kenneth) patch v1 - Improves the test coverage for nodesFromRect. Similarly to bug 47766 (Enrich /fast/dom/nodesFromRect-basic.html test, this patch continues to improve the test coverage for Document::nodesFromRect. This time tests involving links and text nodes are being added this time. Basically it performs various rect hit tests involving the positions of the elements.
Antonio Gomes
Comment 2 2010-10-19 08:13:11 PDT
Comment on attachment 71129 [details] (committed r70058, r=kenneth) patch v1 - Improves the test coverage for nodesFromRect. Clearing flags on attachment: 71129 Committed r70058: <http://trac.webkit.org/changeset/70058>
Antonio Gomes
Comment 3 2010-10-19 13:50:41 PDT
Complementary fixes landed in: http://trac.webkit.org/changeset/70078 (renamed xxx-expected.html to xxx-expected.txt) http://trac.webkit.org/changeset/70080 (skipped the test on gtk, qt and windows).
Antonio Gomes
Comment 4 2010-10-19 14:16:04 PDT
... and http://trac.webkit.org/changeset/70086 (skipped the proper files on Qt, Win and Gtk's DRT). (In reply to comment #3) > Complementary fixes landed in: > > http://trac.webkit.org/changeset/70078 (renamed xxx-expected.html to xxx-expected.txt) > http://trac.webkit.org/changeset/70080 (skipped the test on gtk, qt and windows).
Note You need to log in before you can comment on or make changes to this bug.