|Summary:||Add an inner frame test to Document::nodesFromRect|
|Product:||WebKit||Reporter:||Antonio Gomes <tonikitoo>|
|Component:||Tools / Tests||Assignee:||Antonio Gomes <tonikitoo>|
|Version:||528+ (Nightly build)|
|OS:||OS X 10.5|
Description Antonio Gomes 2010-10-17 22:33:34 PDT
Comment 1 Antonio Gomes 2010-10-19 08:15:53 PDT
I will actually add two layout tests here.
Comment 2 Antonio Gomes 2010-10-19 22:48:31 PDT
Created attachment 71252 [details] (committed r70147, r=kenneth) patch v1 - Improves the test coverage for nodesFromRect. Patch continues to improve the test coverage of Document::nodesFromRect, similarly to bugs 47795 (Add a test to nodesFromRect involving links and text nodes) and 47766 (Enrich fast/dom/nodesFromRect-basic.html test). This time it is being adding tests involving inner frame Three situations are added: 1) Hit testing an inner frame from an outer document should not include nodes of the former in the returned result, but the inner frame itself; 2) Hit testing inner frame and outer frame contents should return all nodes in the later whose area intersect with the hit area and the intersected inner frame itself; 3) Hit testing an inner document content should return all nodes in the inner document whose area intersect the hit area.
Comment 3 Kenneth Rohde Christiansen 2010-10-20 07:50:12 PDT
Comment on attachment 71252 [details] (committed r70147, r=kenneth) patch v1 - Improves the test coverage for nodesFromRect. More test coverage is always good! Any change of you adding LTC::nodesFromRect() support to other ports?
Comment 4 Antonio Gomes 2010-10-20 07:57:25 PDT
(In reply to comment #3) > (From update of attachment 71252 [details]) > More test coverage is always good! Any change of you adding LTC::nodesFromRect() support to other ports? Hopefully for Qt's DRT soon.