Summary: | Add an inner frame test to Document::nodesFromRect | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Antonio Gomes <tonikitoo> | ||||
Component: | Tools / Tests | Assignee: | Antonio Gomes <tonikitoo> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | kenneth, simon.fraser | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Antonio Gomes
2010-10-17 22:33:34 PDT
I will actually add two layout tests here. Created attachment 71252 [details] (committed r70147, r=kenneth) patch v1 - Improves the test coverage for nodesFromRect. Patch continues to improve the test coverage of Document::nodesFromRect, similarly to bugs 47795 (Add a test to nodesFromRect involving links and text nodes) and 47766 (Enrich fast/dom/nodesFromRect-basic.html test). This time it is being adding tests involving inner frame Three situations are added: 1) Hit testing an inner frame from an outer document should not include nodes of the former in the returned result, but the inner frame itself; 2) Hit testing inner frame and outer frame contents should return all nodes in the later whose area intersect with the hit area and the intersected inner frame itself; 3) Hit testing an inner document content should return all nodes in the inner document whose area intersect the hit area. Comment on attachment 71252 [details] (committed r70147, r=kenneth) patch v1 - Improves the test coverage for nodesFromRect. More test coverage is always good! Any change of you adding LTC::nodesFromRect() support to other ports? (In reply to comment #3) > (From update of attachment 71252 [details]) > More test coverage is always good! Any change of you adding LTC::nodesFromRect() support to other ports? Hopefully for Qt's DRT soon. Comment on attachment 71252 [details] (committed r70147, r=kenneth) patch v1 - Improves the test coverage for nodesFromRect. Clearing flags on attachment: 71252 Committed r70147 : <http://trac.webkit.org/changeset/70147> |