RESOLVED FIXED 47794
Add an inner frame test to Document::nodesFromRect
https://bugs.webkit.org/show_bug.cgi?id=47794
Summary Add an inner frame test to Document::nodesFromRect
Antonio Gomes
Reported 2010-10-17 22:33:34 PDT
...
Attachments
(committed r70147, r=kenneth) patch v1 - Improves the test coverage for nodesFromRect. (10.40 KB, patch)
2010-10-19 22:48 PDT, Antonio Gomes
no flags
Antonio Gomes
Comment 1 2010-10-19 08:15:53 PDT
I will actually add two layout tests here.
Antonio Gomes
Comment 2 2010-10-19 22:48:31 PDT
Created attachment 71252 [details] (committed r70147, r=kenneth) patch v1 - Improves the test coverage for nodesFromRect. Patch continues to improve the test coverage of Document::nodesFromRect, similarly to bugs 47795 (Add a test to nodesFromRect involving links and text nodes) and 47766 (Enrich fast/dom/nodesFromRect-basic.html test). This time it is being adding tests involving inner frame Three situations are added: 1) Hit testing an inner frame from an outer document should not include nodes of the former in the returned result, but the inner frame itself; 2) Hit testing inner frame and outer frame contents should return all nodes in the later whose area intersect with the hit area and the intersected inner frame itself; 3) Hit testing an inner document content should return all nodes in the inner document whose area intersect the hit area.
Kenneth Rohde Christiansen
Comment 3 2010-10-20 07:50:12 PDT
Comment on attachment 71252 [details] (committed r70147, r=kenneth) patch v1 - Improves the test coverage for nodesFromRect. More test coverage is always good! Any change of you adding LTC::nodesFromRect() support to other ports?
Antonio Gomes
Comment 4 2010-10-20 07:57:25 PDT
(In reply to comment #3) > (From update of attachment 71252 [details]) > More test coverage is always good! Any change of you adding LTC::nodesFromRect() support to other ports? Hopefully for Qt's DRT soon.
Antonio Gomes
Comment 5 2010-10-20 08:11:48 PDT
Comment on attachment 71252 [details] (committed r70147, r=kenneth) patch v1 - Improves the test coverage for nodesFromRect. Clearing flags on attachment: 71252 Committed r70147 : <http://trac.webkit.org/changeset/70147>
Note You need to log in before you can comment on or make changes to this bug.