Bug 47789

Summary: check-webkit-style needs to ignore underscores in opcode names and vm_throw
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: Tools / TestsAssignee: David Levin <levin>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, levin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Proposed fix. none

Oliver Hunt
Reported 2010-10-17 20:36:14 PDT
check-webkit-style complains about vm_throw, op_..., and underscores in the various CPU opcode defs. This makes it very noisy for JSC and will break the cq
Attachments
Proposed fix. (4.33 KB, patch)
2010-10-17 22:35 PDT, David Levin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Levin
Comment 1 2010-10-17 22:35:00 PDT
Created attachment 71000 [details] Proposed fix.
WebKit Commit Bot
Comment 2 2010-10-18 04:57:56 PDT
Comment on attachment 71000 [details] Proposed fix. Clearing flags on attachment: 71000 Committed r69953: <http://trac.webkit.org/changeset/69953>
WebKit Commit Bot
Comment 3 2010-10-18 04:58:02 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.