Bug 47786

Summary:

Remove explicit passing of user gesture in NavigationScheduler

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

New Bugs

Assignee:

Adam Barth <abarth>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dglazkov, eric, jnd, pkasting

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none

Description Adam Barth 2010-10-17 17:22:49 PDT

Remove explicit passing of user gesture in NavigationScheduler

Comment 1 Adam Barth 2010-10-17 17:25:09 PDT

Created attachment 70988 [details]
Patch

Comment 2 Dimitri Glazkov (Google) 2010-10-17 19:29:52 PDT

Comment on attachment 70988 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=70988&action=review

Thanks for doing this Adam! This turns our previous rabbit-trail method into a much simpler design.

> WebCore/ChangeLog:8
> +        As requested by Mr. Glazkov, remove more explicit passing of the user

Darn it, I gotta tell my Dad to stop trolling WebKit bug tracker.

Comment 3 WebKit Commit Bot 2010-10-17 19:58:57 PDT

The commit-queue encountered the following flaky tests while processing attachment 70988 [details]:

[u'http/tests/security/xssAuditor/script-tag-with-source-entities.html']

Please file bugs against the tests.  The commit-queue is continuing to process your patch.

Comment 4 WebKit Commit Bot 2010-10-17 19:59:45 PDT

Comment on attachment 70988 [details]
Patch

Clearing flags on attachment: 70988

Committed r69938: <http://trac.webkit.org/changeset/69938>

Comment 5 WebKit Commit Bot 2010-10-17 19:59:50 PDT

All reviewed patches have been landed.  Closing bug.