Bug 47758

Summary: Add using declarations for currentTimeMS() and parseDateFromNullTerminatedCharacters()
Product: WebKit Reporter: Kim, kyusun <maniagoon>
Component: Web Template FrameworkAssignee: Nobody <webkit-unassigned>
Severity: Normal CC: ap, beergun, commit-queue, kling, skyul, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Description Flags
Add using clauses
Fixed style error.
kling: review-, kling: commit-queue-
Add using clauses
ap: commit-queue-
Add using declarations none

Description Kim, kyusun 2010-10-15 17:50:50 PDT
Add missing namespaces for currentTimeMS() of CurrentTime.h and parseDateFromNullTerminatedCharacters() of DateMath.h.
Comment 1 Kim, kyusun 2010-10-15 18:06:07 PDT
Created attachment 70935 [details]
Add using clauses
Comment 2 WebKit Review Bot 2010-10-15 18:07:32 PDT
Attachment 70935 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
JavaScriptCore/ChangeLog:5:  Line contains tab character.  [whitespace/tab] [5]
JavaScriptCore/ChangeLog:6:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 2 in 3 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Kim, kyusun 2010-10-15 18:13:14 PDT
Created attachment 70937 [details]
Fixed style error.
Comment 4 Andreas Kling 2010-10-16 03:39:00 PDT
Comment on attachment 70937 [details]
Fixed style error.

View in context: https://bugs.webkit.org/attachment.cgi?id=70937&action=review

Looks fine otherwise.

> JavaScriptCore/ChangeLog:7
> +

Please add the bug URL in the ChangeLog entry.
Comment 5 Kim, kyusun 2010-10-16 13:50:26 PDT
Created attachment 70963 [details]
Add using clauses

Add bug url.
Comment 6 Alexey Proskuryakov 2010-10-16 17:05:06 PDT
Comment on attachment 70963 [details]
Add using clauses

C++ has "using declaration", and "using directive", but not "using clause". The ones you're adding are using declarations. Please correct the ChangeLog.
Comment 7 Kim, kyusun 2010-10-16 17:42:51 PDT
Created attachment 70968 [details]
Add using declarations
Comment 8 Kim, kyusun 2010-10-16 17:44:15 PDT
Comment on attachment 70968 [details]
Add using declarations

"clause" is changed to "declaration".
Comment 9 Alexey Proskuryakov 2010-10-16 21:09:48 PDT
Comment on attachment 70968 [details]
Add using declarations

Thank you!

Now that these have using declarations for these, we can remove namespace prefixes at call sites, as well as perhaps "using WTF;" directives in some files.
Comment 10 Kim, kyusun 2010-10-16 21:15:56 PDT
thank you.
Comment 11 WebKit Commit Bot 2010-10-16 21:43:13 PDT
Comment on attachment 70968 [details]
Add using declarations

Clearing flags on attachment: 70968

Committed r69920: <http://trac.webkit.org/changeset/69920>
Comment 12 WebKit Commit Bot 2010-10-16 21:43:19 PDT
All reviewed patches have been landed.  Closing bug.