Summary: | [GTK] Soup cache code still has some warnings | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Martin Robinson <mrobinson> | ||||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | pnormand, svillar, xan.lopez | ||||||
Priority: | P3 | Keywords: | Gtk | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | Linux | ||||||||
Attachments: |
|
Description
Martin Robinson
2010-10-15 12:54:19 PDT
Created attachment 71148 [details]
proposed patch
Comment on attachment 71148 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=71148&action=review > WebCore/platform/network/soup/cache/webkit/soup-cache.c:302 > The original code would NOT revalidate if the 'must-revalidate' is not present. Your patch changes that so that it WILL revalidate if the key is not there. I don't think that's right? Created attachment 71155 [details]
updated patch
Comment on attachment 71155 [details]
updated patch
Awesome.
Committed r70056: <http://trac.webkit.org/changeset/70056> |