Bug 47707

Summary: Update our clone of Philip Taylor's canvas test suite
Product: WebKit Reporter: Andreas Kling <kling>
Component: CanvasAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: jamesr, mdelaney7
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed patch
none
Proposed patch v2 jamesr: review+

Andreas Kling
Reported 2010-10-14 18:34:21 PDT
Several improvements and additions have been made to the tests upstream since we imported them into LayoutTests/canvas/philip/
Attachments
Proposed patch (1.86 MB, patch)
2010-10-14 18:38 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Proposed patch v2 (1.76 MB, patch)
2010-10-18 03:30 PDT, Andreas Kling 		jamesr: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2010-10-14 18:38:57 PDT
Created attachment 70817 [details] Proposed patch A modest first stab at this.
James Robinson
Comment 2 2010-10-14 19:06:19 PDT
Few general notes: *) please edit down the LayoutTests/ChangeLog file to just list canvas/philip/ and not all the files individually. it doesn't really help to have a 1000+ line changelog entry *) can we record the exact revision of the test suite we have checked in somewhere? maybe in a README or the like?
Andreas Kling
Comment 3 2010-10-14 19:09:37 PDT
Comment on attachment 70817 [details] Proposed patch Removing r?, will continue on this tomorrow..
Andreas Kling
Comment 4 2010-10-18 03:30:40 PDT
Created attachment 71015 [details] Proposed patch v2 Trimmed ChangeLog, added LayoutTests/canvas/philip/README with URL to upstream rev. Also included images this time (yay svn-create-patch!)
James Robinson
Comment 5 2010-10-28 14:43:15 PDT
Comment on attachment 71015 [details] Proposed patch v2 Whoops! I totally forgot about this. Looks great.
Matthew Delaney
Comment 6 2010-10-28 15:03:56 PDT
Andreas, awesome! Could we keep these failing tests off the skipped list and just update the expectation files for the specific platforms (at least in the mac world, i.e. mac-snowleopard). I just landed a patch earlier today to unskip all the tests that we want to track the progressions/regressions of. If it's a hassle for you to check on the mac platforms, you could just leave them skipped in this patch and make a follow up bug to unskip the ones that we want to track. Thanks!
Andreas Kling
Comment 7 2010-11-07 05:50:06 PST
Committed r71481: <http://trac.webkit.org/changeset/71481>
Note You need to log in before you can comment on or make changes to this bug.