| Summary: | Update our clone of Philip Taylor's canvas test suite | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andreas Kling <kling> | ||||||
| Component: | Canvas | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | jamesr, mdelaney7 | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Attachments: |
|
||||||||
|
Description
Andreas Kling
2010-10-14 18:34:21 PDT
Created attachment 70817 [details]
Proposed patch
A modest first stab at this.
Few general notes: *) please edit down the LayoutTests/ChangeLog file to just list canvas/philip/ and not all the files individually. it doesn't really help to have a 1000+ line changelog entry *) can we record the exact revision of the test suite we have checked in somewhere? maybe in a README or the like? Comment on attachment 70817 [details]
Proposed patch
Removing r?, will continue on this tomorrow..
Created attachment 71015 [details]
Proposed patch v2
Trimmed ChangeLog, added LayoutTests/canvas/philip/README with URL to upstream rev.
Also included images this time (yay svn-create-patch!)
Comment on attachment 71015 [details]
Proposed patch v2
Whoops! I totally forgot about this. Looks great.
Andreas, awesome! Could we keep these failing tests off the skipped list and just update the expectation files for the specific platforms (at least in the mac world, i.e. mac-snowleopard). I just landed a patch earlier today to unskip all the tests that we want to track the progressions/regressions of. If it's a hassle for you to check on the mac platforms, you could just leave them skipped in this patch and make a follow up bug to unskip the ones that we want to track. Thanks! Committed r71481: <http://trac.webkit.org/changeset/71481> |