Summary: | [GTK] Needs fixing mistyped comments in the API documentation | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joone Hur <joone> | ||||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, gustavo, mrobinson, xan.lopez | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Joone Hur
2010-10-13 23:48:01 PDT
Created attachment 70717 [details]
Proposed Patch1
Comment on attachment 70717 [details] Proposed Patch1 View in context: https://bugs.webkit.org/attachment.cgi?id=70717&action=review > WebKit/gtk/webkit/webkitwebsettings.cpp:49 > - * the to be used text encoding, color, font sizes, printing mode, > + * the behaviour to be used text encoding, color, font sizes, printing mode, This change looks wrong. The grammar is a bit weird the way it is now, but not sure it's wrong - would be good to have input from a native English speaker =D (In reply to comment #2) > This change looks wrong. The grammar is a bit weird the way it is now, but not sure it's wrong - would be good to have input from a native English speaker =D Looks wrong indeed. I'd just do s/the to be used/its/ in the original text. But I agree with having Martin just put there something ;) (In reply to comment #2) > (From update of attachment 70717 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=70717&action=review > > > WebKit/gtk/webkit/webkitwebsettings.cpp:49 > > - * the to be used text encoding, color, font sizes, printing mode, > > + * the behaviour to be used text encoding, color, font sizes, printing mode, > > This change looks wrong. The grammar is a bit weird the way it is now, but not sure it's wrong - would be good to have input from a native English speaker =D How about this? #WebKitWebSettings can be applied to a #WebKitWebView to control the behaviour to be used, text encoding, color, font sizes, printing mode, script support, loading of images and various other things. Here's my suggestion: (old) WebKitWebSettings can be applied to a WebKitWebView to control the to be used text encoding, color, font sizes, printing mode, script support, loading of images and various other things. (new) WebKitWebSettings can be applied to a WebKitWebView to control text encoding, color, font sizes, printing mode, script support, loading of images and various other things. After creation, a WebKitWebSettings object contains default settings. Created attachment 70822 [details]
Proposed Patch2
Thanks, Martin. I applied your suggestion to the patch.
Thanks! Comment on attachment 70822 [details] Proposed Patch2 Clearing flags on attachment: 70822 Committed r70036: <http://trac.webkit.org/changeset/70036> All reviewed patches have been landed. Closing bug. |