Bug 47642 – Label media/video-source-error test SLOW instead of TIMEOUT

• Component: New Bugs
• Status: RESOLVED INVALID

Label media/video-source-error test SLOW instead of TIMEOUT

Created attachment 70695 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 70695 [details]
Patch

OK.

[WebKit Review Bot]

Comment on attachment 70695 [details]
Patch

Rejecting attachment 70695 [details] from commit-queue.

Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=abarth-cq-sl', 'apply-attachment', '--non-interactive', 70695]" exit_code: 2
Last 500 characters of output:
', u'--reviewer', u'Eric Seidel', u'--force']" exit_code: 1
Parsed 2 diffs from patch file(s).
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/platform/chromium/test_expectations.txt
Hunk #1 FAILED at 698.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/chromium/test_expectations.txt.rej

Failed to run "[u'/Users/abarth/git/webkit-queue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Eric Seidel', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/6934052

[Ojan Vafai]

Comment on attachment 70695 [details]
Patch

I'm skeptical this is correct. When the test passes it takes <1 second (see http://test-results.appspot.com/dashboards/flakiness_dashboard.html#master=webkit.org&tests=media%2Fvideo-source-error.html, the empty boxes mean it took < 1 second). That implies that it's not just a slow test and that there is some logic error causing it to timeout. Marking it slow gives it more time to run, but I doubt that it would pass then. Do you understand why it times out sometimes?

[Eric Seidel (no email)]

Comment on attachment 70695 [details]
Patch

Patch does not apply.