Bug 47641 – Restore normal meaning of double-click on patch review page?

• Component: WebKit Website
• Status: RESOLVED FIXED

[Darin Adler]

I think that clicking on line numbers is a fine way to select ranges to code to comment on. I find the double-click-to-comment behavior frustrating. I want to select words from the source code and paste them into my comments, but I end up creating new empty comments.

Can we remove the double-clicking behavior?

[Adam Barth]

Do you still feel this way, or have you gotten used to double-click-to-comment?

[Alexey Proskuryakov]

I'm not the original reporter, but this is still an issue for me.

[Darin Adler]

(In reply to comment #1)
> Do you still feel this way, or have you gotten used to double-click-to-comment?

Yes. I feel it more strongly now since I have used the patch review page much more.

I never use double click to comment. I click on the line numbers instead, which is quite convenient.

I occasionally get an unexpected comment box, then when mentally reviewing what I had just done I realize that I double clicked. I am accustomed to using double click to select words anywhere I can select text, and it’s useful to select parts of the patch to paste into review comments or search.

I run into this much more often now than back in October when I wrote the bug report. So much that I was about to write a bug report about it this week, not remembering I had already done so.

[Adam Barth]

Okiedokes.  I'll remove the behavior then.  Thanks.

[Adam Barth]

Created attachment 73280 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 73280 [details]
Patch

I likes it!

[Adam Barth]

Committed r71570: <http://trac.webkit.org/changeset/71570>