Bug 47641

Summary:

Restore normal meaning of double-click on patch review page?

Product:

WebKit

Reporter:

Darin Adler <darin>

Component:

WebKit Website

Assignee:

Adam Barth <abarth>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	eric: review+, eric: commit-queue+

Description Darin Adler 2010-10-13 17:45:49 PDT

I think that clicking on line numbers is a fine way to select ranges to code to comment on. I find the double-click-to-comment behavior frustrating. I want to select words from the source code and paste them into my comments, but I end up creating new empty comments.

Can we remove the double-clicking behavior?

Comment 1 Adam Barth 2010-11-07 16:27:38 PST

Do you still feel this way, or have you gotten used to double-click-to-comment?

Comment 2 Alexey Proskuryakov 2010-11-07 20:51:30 PST

I'm not the original reporter, but this is still an issue for me.

Comment 3 Darin Adler 2010-11-08 10:17:51 PST

(In reply to comment #1)
> Do you still feel this way, or have you gotten used to double-click-to-comment?

Yes. I feel it more strongly now since I have used the patch review page much more.

I never use double click to comment. I click on the line numbers instead, which is quite convenient.

I occasionally get an unexpected comment box, then when mentally reviewing what I had just done I realize that I double clicked. I am accustomed to using double click to select words anywhere I can select text, and it’s useful to select parts of the patch to paste into review comments or search.

I run into this much more often now than back in October when I wrote the bug report. So much that I was about to write a bug report about it this week, not remembering I had already done so.

Comment 4 Adam Barth 2010-11-08 10:41:38 PST

Okiedokes.  I'll remove the behavior then.  Thanks.

Comment 5 Adam Barth 2010-11-08 14:10:12 PST

Created attachment 73280 [details]
Patch

Comment 6 Eric Seidel (no email) 2010-11-08 14:12:45 PST

Comment on attachment 73280 [details]
Patch

I likes it!

Comment 7 Adam Barth 2010-11-08 14:18:31 PST

Committed r71570: <http://trac.webkit.org/changeset/71570>