Bug 47637

Summary:

Break LayoutTestResults out into its own file

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

New Bugs

Assignee:

Eric Seidel (no email) <eric>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, dpranke, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none
Patch	none

Eric Seidel (no email)

Reported 2010-10-13 16:51:53 PDT

Break LayoutTestResults out into its own file

Attachments
Patch (14.68 KB, patch) 2010-10-13 16:52 PDT, Eric Seidel (no email)	no flags	Details Formatted Diff Diff
Patch (14.68 KB, patch) 2010-10-13 17:02 PDT, Eric Seidel (no email)	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Eric Seidel (no email)

Comment 1 2010-10-13 16:52:29 PDT

Created attachment 70684 [details] Patch

Eric Seidel (no email)

Comment 2 2010-10-13 16:54:25 PDT

There is one "style error" in this patch, but I believe pep8.py is wrong, the pep8 recommendation doesn't mention multi-line dictionaries.

WebKit Review Bot

Comment 3 2010-10-13 16:55:44 PDT

Attachment 70684 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKitTools/Scripts/webkitpy/common/net/layouttestresults_unittest.py:66: whitespace before '}' [pep8/E202] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.

Eric Seidel (no email)

Comment 4 2010-10-13 17:02:17 PDT

Created attachment 70685 [details] Patch

Adam Barth

Comment 5 2010-10-13 22:54:24 PDT

Comment on attachment 70685 [details] Patch Clearing flags on attachment: 70685 Committed r69740: <http://trac.webkit.org/changeset/69740>

Adam Barth

Comment 6 2010-10-13 22:54:29 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.