Bug 47637 - Break LayoutTestResults out into its own file
Summary: Break LayoutTestResults out into its own file
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-10-13 16:51 PDT by Eric Seidel (no email)
Modified: 2010-10-13 22:54 PDT (History)
3 users (show)

See Also:


Attachments
Patch (14.68 KB, patch)
2010-10-13 16:52 PDT, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff
Patch (14.68 KB, patch)
2010-10-13 17:02 PDT, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2010-10-13 16:51:53 PDT
Break LayoutTestResults out into its own file
Comment 1 Eric Seidel (no email) 2010-10-13 16:52:29 PDT
Created attachment 70684 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-10-13 16:54:25 PDT
There is one "style error" in this patch, but I believe pep8.py is wrong, the pep8 recommendation doesn't mention multi-line dictionaries.
Comment 3 WebKit Review Bot 2010-10-13 16:55:44 PDT
Attachment 70684 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKitTools/Scripts/webkitpy/common/net/layouttestresults_unittest.py:66:  whitespace before '}'  [pep8/E202] [5]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Eric Seidel (no email) 2010-10-13 17:02:17 PDT
Created attachment 70685 [details]
Patch
Comment 5 Adam Barth 2010-10-13 22:54:24 PDT
Comment on attachment 70685 [details]
Patch

Clearing flags on attachment: 70685

Committed r69740: <http://trac.webkit.org/changeset/69740>
Comment 6 Adam Barth 2010-10-13 22:54:29 PDT
All reviewed patches have been landed.  Closing bug.