Bug 47625

Summary:

Run layout tests when GL fails to initialize

Product:

WebKit

Reporter:

Hin-Chung Lam <hclam>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

NEW

Severity:

Normal

CC:

abarth, hclam, jamesr, vangelis, vrk

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
patch	levin: review-

Hin-Chung Lam

Reported 2010-10-13 15:30:49 PDT

test_shell and DRT uses Mesa which doesn't test that case when GL fails to initialize. The first step is to have the tools be able to fail the initialization when running the layout test. The second step is to allow layout test to control that in the script.

Attachments
patch (2.20 KB, patch) 2010-10-13 15:37 PDT, Hin-Chung Lam	levin: review-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Hin-Chung Lam

Comment 1 2010-10-13 15:37:44 PDT

Created attachment 70674 [details] patch

James Robinson

Comment 2 2010-10-13 15:41:41 PDT

Do we want --use-gl or some flag to explicitly toggle whether context initialization fails? This flag doesn't seem to describe what it does very well.

Victoria Kirst

Comment 3 2010-10-13 15:43:16 PDT

(In reply to comment #2) > Do we want --use-gl or some flag to explicitly toggle whether context initialization fails? This flag doesn't seem to describe what it does very well. I agree, I think it would make more sense to have an explicit flag for testing the case where the GL initialization fails.

Hin-Chung Lam

Comment 4 2010-10-13 15:47:05 PDT

what about --no-gl-context?

David Levin

Comment 5 2010-10-13 20:47:13 PDT

Comment on attachment 70674 [details] patch Based on comments already in the bug.

Note You need to log in before you can comment on or make changes to this bug.