Bug 47605

Summary: Add DATABASE guard on code using DatabaseAuthorizer.
Product: WebKit Reporter: Hyung Song <beergun>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: UNCONFIRMED ---    
Severity: Normal CC: dumi, ericu, eric, kling, skyul
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch. Add DATABASE guard. eric: review-

Description Hyung Song 2010-10-13 11:05:35 PDT
BrewMP will use sqlite3 without enabling DATABASE.
So DatabaseAuthorizer is not used.
Comment 1 Hyung Song 2010-10-13 11:25:08 PDT
Created attachment 70634 [details]
Patch. Add DATABASE guard.
Comment 2 Dumitru Daniliuc 2010-10-14 10:54:38 PDT
Comment on attachment 70634 [details]
Patch. Add DATABASE guard.

instead of hiding the authorizer behind the ENABLE(DATABASE) switch, i think we should rather hide it behind the BREWMP port switch.
Comment 3 Eric Seidel (no email) 2010-10-14 10:55:06 PDT
This seems like it will fail due to unused parameter warnings.

Ideally a database person would comment here.
Comment 4 Kwang Yul Seo 2010-11-14 16:47:34 PST
Ping!
Comment 5 Eric Seidel (no email) 2010-12-13 00:38:07 PST
Comment on attachment 70634 [details]
Patch. Add DATABASE guard.

This is going to fail due to an unused param.  There is an UNUSED_ARG macro or UNUSED_PARAM or something like that.