Summary: | [GTK] Small cleanup in PluginViewGtk | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Xan Lopez <xan.lopez> | ||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, mrobinson, xan.lopez | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Xan Lopez
2010-10-13 06:37:53 PDT
Created attachment 70605 [details]
cleanup.diff
How did this code originate? Is it important to preserve the assertion? (In reply to comment #2) > How did this code originate? Is it important to preserve the assertion? The actualDepth was used before to see if we have an alpha channel, but in the current code we use cairo_surface_get_content for that. We can still keep the assertion (doing it differently) if you think it's important, I'm not very sure that it is. Comment on attachment 70605 [details]
cleanup.diff
Seems reasonable.
Comment on attachment 70605 [details] cleanup.diff Clearing flags on attachment: 70605 Committed r69793: <http://trac.webkit.org/changeset/69793> All reviewed patches have been landed. Closing bug. |