Bug 47563

Summary: Pass platform path (rather than virtual path) when creating File from FileEntry
Product: WebKit Reporter: Kinuko Yasuda <kinuko>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ericu, jianli
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch jianli: review+

Kinuko Yasuda
Reported 2010-10-12 17:24:31 PDT
Pass platform path (irather than virtual path) when creating File from FileEntry.
Attachments
Patch (1.30 KB, patch)
2010-10-12 17:39 PDT, Kinuko Yasuda 		no flags
DetailsFormatted DiffDiff
Patch (1.33 KB, patch)
2010-10-12 17:45 PDT, Kinuko Yasuda 		jianli: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kinuko Yasuda
Comment 1 2010-10-12 17:39:51 PDT
Created attachment 70575 [details] Patch
Kinuko Yasuda
Comment 2 2010-10-12 17:45:50 PDT
Created attachment 70576 [details] Patch Sorry I sent an wrong one.
Eric U.
Comment 3 2010-10-12 17:56:31 PDT
Comment on attachment 70576 [details] Patch LGTM.
Jian Li
Comment 4 2010-10-12 18:02:49 PDT
One suggestion. Consider renaming m_fullPath in EntryBase to m_virtualPath or m_fullVirtualPath to improve reability and avoid future mistake. Or at least you can add the comment in EntryBase.h.
Kinuko Yasuda
Comment 5 2010-10-12 18:40:43 PDT
(In reply to comment #4) > One suggestion. Consider renaming m_fullPath in EntryBase to m_virtualPath or m_fullVirtualPath to improve reability and avoid future mistake. Or at least you can add the comment in EntryBase.h. Thanks, I'll make a separate patch to rename all.
Kinuko Yasuda
Comment 6 2010-10-12 18:59:44 PDT
(In reply to comment #5) > (In reply to comment #4) > > One suggestion. Consider renaming m_fullPath in EntryBase to m_virtualPath or m_fullVirtualPath to improve reability and avoid future mistake. Or at least you can add the comment in EntryBase.h. > > Thanks, I'll make a separate patch to rename all. Hmm, on the second thought m_fullPath was named after FileEntry.fullPath attribute. I'm going to put the comment to indicate it's virtual path.
Kinuko Yasuda
Comment 7 2010-10-12 19:27:04 PDT
Committed r69634: <http://trac.webkit.org/changeset/69634>
Note You need to log in before you can comment on or make changes to this bug.