Bug 47553

Summary: Add a simple Find UI to MiniBrowser
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch sam: review+

Anders Carlsson
Reported 2010-10-12 13:15:18 PDT
Add a simple Find UI to MiniBrowser
Attachments
Patch (136.07 KB, patch)
2010-10-12 13:16 PDT, Anders Carlsson 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2010-10-12 13:16:27 PDT
Created attachment 70559 [details] Patch
Sam Weinig
Comment 2 2010-10-12 13:20:26 PDT
Comment on attachment 70559 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=70559&action=review > WebKitTools/MiniBrowser/mac/BrowserWindowController.m:667 > +- (IBAction)performFindPanelAction:(id)sender { > + [findPanelWindow makeKeyAndOrderFront:sender]; > +} > + > +- (IBAction)find:(id)sender { > + WKStringRef string = WKStringCreateWithCFString((CFStringRef)[sender stringValue]); The { should be on the next line.
Anders Carlsson
Comment 3 2010-10-12 13:28:37 PDT
Committed r69595: <http://trac.webkit.org/changeset/69595>
Note You need to log in before you can comment on or make changes to this bug.